mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Wang Long <long.wanglong@huawei.com>
Cc: <gregkh@linuxfoundation.org>, <rostedt@goodmis.org>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<peifeiyue@huawei.com>, <wanglong@laoqinren.net>
Subject: Re: [PATCH] Documentation: Update filesystems/debugfs.txt
Date: Thu, 16 Jul 2015 03:37:04 -0600	[thread overview]
Message-ID: <20150716033704.7a4e1a5b@lwn.net> (raw)
In-Reply-To: <1437028276-107088-1-git-send-email-long.wanglong@huawei.com>

On Thu, 16 Jul 2015 06:31:16 +0000
Wang Long <long.wanglong@huawei.com> wrote:

> This patch update the Documentation/filesystems/debugfs.txt
> file. The main work is to add the description of the following
> functions:
>     debugfs_create_atomic_t
>     debugfs_create_u32_array
>     debugfs_create_devm_seqfile
>     debugfs_create_file_size

I'll apply this because it's a definite improvement over what is there
now, but it would be nice to describe these functions a bit more in
detail.  In particular, a name like debugfs_create_devm_seqfile() will
cause at least some developers to think it will clean itself up when the
device goes away, but that does not appear to actually be the case...

>  Copyright 2009 Jonathan Corbet <corbet@lwn.net>
> +Updated by Wang Long <long.wanglong@huawei.com> on 2015/07/16

I think I'll drop that line, though; that's what the source code
management system is for.  Arguably the line it follows doesn't really
need to be there either...

Thanks,

jon

      reply	other threads:[~2015-07-16  9:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16  6:31 Wang Long
2015-07-16  9:37 ` Jonathan Corbet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150716033704.7a4e1a5b@lwn.net \
    --to=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=long.wanglong@huawei.com \
    --cc=peifeiyue@huawei.com \
    --cc=rostedt@goodmis.org \
    --cc=wanglong@laoqinren.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome