Re: next-20150716 build: 4 failures 88 warnings (next-20150716)

Re: next-20150716 build: 4 failures 88 warnings (next-20150716)

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

On Thu, Jul 16, 2015 at 11:05:11AM +0100, Build bot for Mark Brown wrote:

Today's linux-next fails to build an arm64 allnoconfig due to "mm: make
GUP handle pfn mapping unless FOLL_GET is requested" which causes:

> 	arm64-allnoconfig
> ../mm/gup.c:51:4: error: implicit declaration of function 'update_mmu_cache' [-Werror=implicit-function-declaration]

The update_mmu_cache() function is defined unconditionally in
asm/tlbflush.h so there is presumably some path of conditional
inclusions which causes it not to get declared in an allnoconfig - I
didn't chase that down yet.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: next-20150716 build: 4 failures 88 warnings (next-20150716)

[Catalin Marinas]

On Thu, Jul 16, 2015 at 02:41:52PM +0100, Mark Brown wrote:
> On Thu, Jul 16, 2015 at 11:05:11AM +0100, Build bot for Mark Brown wrote:
> 
> Today's linux-next fails to build an arm64 allnoconfig due to "mm: make
> GUP handle pfn mapping unless FOLL_GET is requested" which causes:
> 
> > 	arm64-allnoconfig
> > ../mm/gup.c:51:4: error: implicit declaration of function 'update_mmu_cache' [-Werror=implicit-function-declaration]
> 
> The update_mmu_cache() function is defined unconditionally in
> asm/tlbflush.h so there is presumably some path of conditional
> inclusions which causes it not to get declared in an allnoconfig - I
> didn't chase that down yet.

Maybe we should move it to asm/pgtable.h like many other architectures.

-- 
Catalin

Re: next-20150716 build: 4 failures 88 warnings (next-20150716)

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

On Thu, Jul 16, 2015 at 02:48:36PM +0100, Catalin Marinas wrote:
> On Thu, Jul 16, 2015 at 02:41:52PM +0100, Mark Brown wrote:

> > The update_mmu_cache() function is defined unconditionally in
> > asm/tlbflush.h so there is presumably some path of conditional
> > inclusions which causes it not to get declared in an allnoconfig - I
> > didn't chase that down yet.

> Maybe we should move it to asm/pgtable.h like many other architectures.

Seems likely to be more robust in future if we're consistent...

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: next-20150716 build: 4 failures 88 warnings (next-20150716)

[Andrew Morton]

On Thu, 16 Jul 2015 14:41:52 +0100 Mark Brown <broonie@kernel.org> wrote:

> On Thu, Jul 16, 2015 at 11:05:11AM +0100, Build bot for Mark Brown wrote:
> 
> Today's linux-next fails to build an arm64 allnoconfig due to "mm: make
> GUP handle pfn mapping unless FOLL_GET is requested" which causes:
> 
> > 	arm64-allnoconfig
> > ../mm/gup.c:51:4: error: implicit declaration of function 'update_mmu_cache' [-Werror=implicit-function-declaration]
> 
> The update_mmu_cache() function is defined unconditionally in
> asm/tlbflush.h so there is presumably some path of conditional
> inclusions which causes it not to get declared in an allnoconfig - I
> didn't chase that down yet.

I did te obvious:

--- a/mm/gup.c~mm-make-gup-handle-pfn-mapping-unless-foll_get-is-requested-fix
+++ a/mm/gup.c
@@ -12,7 +12,9 @@
 #include <linux/sched.h>
 #include <linux/rwsem.h>
 #include <linux/hugetlb.h>
+
 #include <asm/pgtable.h>
+#include <asm/tlbflush.h>
 
 #include "internal.h"
 

I don't have arm64 toolchain here, but it fixed the error on arm and
that's what mm/memory.c does.