mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Young <dyoung@redhat.com>
To: Baoquan He <bhe@redhat.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, bp@suse.de,
	akpm@linux-foundation.org, jkosina@suse.cz, vgoyal@redhat.com,
	linux-kernel@vger.kernel.org, yinghai@kernel.org
Subject: Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed
Date: Tue, 21 Jul 2015 16:23:44 +0800	[thread overview]
Message-ID: <20150721082343.GC30649@dhcp-129-220.nay.redhat.com> (raw)
In-Reply-To: <20150721075011.GC16747@dhcp-128-28.nay.redhat.com>

On 07/21/15 at 03:50pm, Baoquan He wrote:
> Hi Dave,
> 
> On 07/21/15 at 03:31pm, Dave Young wrote:
> > Hi, Baoquan
> > 
> > The interface was introduced by Yinghai, ccing him.
> > 
> > On 07/19/15 at 10:53pm, Baoquan He wrote:
> > > People reported that when allocating crashkernel memory using
> > > ",high" and ",low" syntax, there were cases where the reservation
> > > of the "high" portion succeeds, but the reservation of the "low"
> > > portion fails. Then kexec can load kdump kernel successfully, but
> > > the boot of kdump kernel fails as there's no low memory. This is
> > > because allocation of low memory for kdump kernel can fail on large
> > > systems for reasons. E.g it could be manually specified crashkernel
> > > low memory is too large to find in memblock region.
> > > 
> > > In this patch add return value for reserve_crashkernel_low. Then put
> > > the crashkernel low memory reserving earlier, just between finding
> > > the crashkernel high memory region and reserving crashkernel high
> > > memory. Then if crashkernel low memory reserving failed we do not
> > > reserve crashkernel high memory but return immediately. Users can
> > > take measures when they found kdump kernel cann't be loaded
> > > successfully.
> > 
> > So we have 3 sementics now,
> > crashkernel ,low
> > crashkernel ,high
> > crashkernel ,low + crashkernel ,high
> > For the last case, we need make sure both ,low and ,high reserved,
> > 
> > Can we assume we need both ,low and ,high being ok if one specify
> > these two types in kernel cmdline?
> 
> I think so. the reason why ,low is introduced is swiotlb or pci device
> need low memory when crashkernel is reserved above 4G. Low memory is
> necessary when ,high is specified unless user can make sure their
> machines don't need low memory and specify crashkernel=0,low explictly.

I think forcing user to provide crashkernel=0,low even they do not need
is bad, IMHO one should provided crashkernel value they really need..

> 
> > 
> > Also in case one suceed, another fail, should we free the reserved memory?
> 
> In this patch it doesn't need to free. Since it just finds an available
> memblock region for crashkernel high, then try to reserve crashkernel
> low memory. If low memory failed to allocate, it doesn't allocate
> crashkernel high memory found, but return immediately. Only if low
> memory is allocated successfully, high memory is allocated too
> subsequently.

Ok, thanks for explanation
Dave

  reply	other threads:[~2015-07-21  8:23 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-19 11:07 [PATCH] " Baoquan He
2015-07-19 13:40 ` Borislav Petkov
2015-07-19 14:23   ` Baoquan He
2015-07-19 14:53 ` [PATCH v2] " Baoquan He
2015-07-21  7:31   ` Dave Young
2015-07-21  7:38     ` Ingo Molnar
2015-07-21  8:19       ` Dave Young
2015-07-22  1:13       ` Baoquan He
2015-07-27 14:45       ` Joerg Roedel
2015-07-21  7:50     ` Baoquan He
2015-07-21  8:23       ` Dave Young [this message]
2015-07-21  8:58         ` Baoquan He
2015-07-21 19:22           ` Yinghai Lu
2015-07-22  0:59             ` Baoquan He
2015-07-22 23:47               ` Yinghai Lu
2015-07-28  0:52                 ` Baoquan He
2015-07-28  2:45                   ` Yinghai Lu
2015-07-28  9:19                     ` Baoquan He
2015-07-22  4:47             ` Minfei Huang
2015-07-22 23:44               ` Yinghai Lu
2015-07-22 10:11             ` Joerg Roedel
2015-07-22 23:41               ` Yinghai Lu
2015-07-27 14:03                 ` Joerg Roedel
2015-07-27 18:31     ` Yinghai Lu
2015-07-27 23:32       ` Baoquan He
2015-07-27 14:41   ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150721082343.GC30649@dhcp-129-220.nay.redhat.com \
    --to=dyoung@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=bp@suse.de \
    --cc=hpa@zytor.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=vgoyal@redhat.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®