mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Dave Young <dyoung@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Borislav Petkov <bp@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jiri Kosina <jkosina@suse.cz>, Vivek Goyal <vgoyal@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed
Date: Tue, 28 Jul 2015 07:32:19 +0800	[thread overview]
Message-ID: <20150727233219.GA1720@dhcp-17-102.nay.redhat.com> (raw)
In-Reply-To: <CAE9FiQU4xLUQHT3335K82gPXQJtdsVDPUg_OwOVU8JZWWV+W+g@mail.gmail.com>

On 07/27/15 at 11:31am, Yinghai Lu wrote:
> >>  #else
> >>  static void __init reserve_crashkernel(void)
> 
> No, you can not move the calling position for reserve_crashkernel_low().
> 
> old sequence:
> 
> memblock_find_in_range  for high
> memblock_reserve for high
> memblock_find_in_range  for low
> memblock_reserve for low
> 
> now you change to:
> memblock_find_in_range  for high
> memblock_find_in_range  for low
> memblock_reserve for low
> memblock_reserve for high
> 
> during memblock_reserve, we would double the memblock reserve array.
> So there is possibility that new membock reserve array is overlapped with
> range for  crashdump high.
> 
> so you should keep the old sequence, and if reserve_crashkernel_low fail,
> just call memblock_free to free high range that is reserved before.

Right, memblock_double_array need avoid the required region. Will
repost.

> 
> Thanks
> 
> Yinghai

  reply	other threads:[~2015-07-27 23:32 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-19 11:07 [PATCH] " Baoquan He
2015-07-19 13:40 ` Borislav Petkov
2015-07-19 14:23   ` Baoquan He
2015-07-19 14:53 ` [PATCH v2] " Baoquan He
2015-07-21  7:31   ` Dave Young
2015-07-21  7:38     ` Ingo Molnar
2015-07-21  8:19       ` Dave Young
2015-07-22  1:13       ` Baoquan He
2015-07-27 14:45       ` Joerg Roedel
2015-07-21  7:50     ` Baoquan He
2015-07-21  8:23       ` Dave Young
2015-07-21  8:58         ` Baoquan He
2015-07-21 19:22           ` Yinghai Lu
2015-07-22  0:59             ` Baoquan He
2015-07-22 23:47               ` Yinghai Lu
2015-07-28  0:52                 ` Baoquan He
2015-07-28  2:45                   ` Yinghai Lu
2015-07-28  9:19                     ` Baoquan He
2015-07-22  4:47             ` Minfei Huang
2015-07-22 23:44               ` Yinghai Lu
2015-07-22 10:11             ` Joerg Roedel
2015-07-22 23:41               ` Yinghai Lu
2015-07-27 14:03                 ` Joerg Roedel
2015-07-27 18:31     ` Yinghai Lu
2015-07-27 23:32       ` Baoquan He [this message]
2015-07-27 14:41   ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150727233219.GA1720@dhcp-17-102.nay.redhat.com \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@suse.de \
    --cc=dyoung@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=vgoyal@redhat.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®