From: Steven Rostedt <rostedt@goodmis.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: David Ahern <dsahern@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Borislav Petkov <bp@suse.de>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Stephane Eranian <eranian@google.com>,
Ingo Molnar <mingo@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver
Date: Thu, 23 Jul 2015 14:11:33 -0400 [thread overview]
Message-ID: <20150723141133.4065321e@gandalf.local.home> (raw)
In-Reply-To: <20150723141039.1bd48bf2@gandalf.local.home>
On Thu, 23 Jul 2015 14:10:39 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Thu, 23 Jul 2015 14:25:54 -0300
> Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
> > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> > index cc25f059ab3d..2750e7e7efff 100644
> > --- a/tools/lib/traceevent/event-parse.c
> > +++ b/tools/lib/traceevent/event-parse.c
> > @@ -418,7 +418,7 @@ static int func_map_init(struct pevent *pevent)
> > }
> >
> > static struct func_map *
> > -find_func(struct pevent *pevent, unsigned long long addr)
> > +__find_func(struct pevent *pevent, unsigned long long addr)
> > {
> > struct func_map *func;
> > struct func_map key;
> > @@ -434,6 +434,51 @@ find_func(struct pevent *pevent, unsigned long long addr)
> > return func;
> > }
> >
> > +static struct {
> > + pevent_function_resolver_t *function;
> > + void *priv;
> > +} function_resolver;
> > +
> > +/**
> > + * pevent_set_function_resolver - set an alternative function resolver
> > + * @resolver - function to be used
> > + * @priv - resolver function private state.
> > + *
> > + * Some tools may have already a way to resolve kernel functions, allow them
> > + * to keep using it instead of duplicating all the entries inside pevent->funclist.
> > + */
> > +void pevent_set_function_resolver(pevent_function_resolver_t *resolver, void *priv)
> > +{
> > + function_resolver.function = resolver;
> > + function_resolver.priv = priv;
>
> What about passing in pevent, and making the allocation here?
In fact, we could remove the global function_resolver, and allocate
that here too.
-- Steve
>
> -- Steve
>
> > +}
> > +
next prev parent reply other threads:[~2015-07-23 18:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 15:04 Arnaldo Carvalho de Melo
2015-07-23 16:21 ` Steven Rostedt
2015-07-23 17:25 ` Arnaldo Carvalho de Melo
2015-07-23 18:10 ` Steven Rostedt
2015-07-23 18:11 ` Steven Rostedt [this message]
2015-07-23 18:17 ` Arnaldo Carvalho de Melo
2015-07-23 21:25 ` Arnaldo Carvalho de Melo
2015-07-23 21:35 ` Steven Rostedt
2015-07-23 21:52 ` Arnaldo Carvalho de Melo
2015-07-23 21:58 ` Arnaldo Carvalho de Melo
2015-07-23 22:07 ` Steven Rostedt
2015-07-24 1:34 ` Arnaldo Carvalho de Melo
2015-07-24 1:46 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150723141133.4065321e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=bp@suse.de \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®