Fix one source file coding sytle issue.

Fix one source file coding sytle issue.

[Incarnation P. Lee]

drivers/staging/lustre/lustre/obdclass/cl_page.c

Signed-off-by: Incarnation P. Lee <incarnation.p.lee@outlook.com>

Re: Fix one source file coding sytle issue.

[Frans Klaver]

Hi,

On Thu, Jul 23, 2015 at 8:20 AM, Incarnation P. Lee
<incarnation.p.lee@outlook.com> wrote:
> drivers/staging/lustre/lustre/obdclass/cl_page.c

It is custom that you write slightly more introductory text here. Just
a file name is pointless.

The subject should probably contain [PATCH 0/5]. This would be
automatically fixed for you when using 'git format-patch
--cover-letter ...'.

The other patches should at least mention the area of the kernel the
change is done in:

  [PATCH N/5] staging: lustre: fix a missing space after comma

So that it becomes immediately clear where the change is done, and
what it is supposed to achieve.


> Signed-off-by: Incarnation P. Lee <incarnation.p.lee@outlook.com>

That's not necessary in the cover letter.

Frans

[PATCH 1/5] Add blank line under variable declaration.

[Incarnation P. Lee]

Signed-off-by: Incarnation P. Lee <incarnation.p.lee@outlook.com>

---
 drivers/staging/lustre/lustre/obdclass/cl_page.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c b/drivers/staging/lustre/lustre/obdclass/cl_page.c
index a7f3032..8b2c1e7 100644
--- a/drivers/staging/lustre/lustre/obdclass/cl_page.c
+++ b/drivers/staging/lustre/lustre/obdclass/cl_page.c
@@ -169,6 +169,7 @@ int cl_page_gang_lookup(const struct lu_env *env, struct cl_object *obj,
 	while ((nr = radix_tree_gang_lookup(&hdr->coh_tree, (void **)pvec,
 					    idx, CLT_PVEC_SIZE)) > 0) {
 		int end_of_region = 0;
+
 		idx = pvec[nr - 1]->cp_index + 1;
 		for (i = 0, j = 0; i < nr; ++i) {
 			page = pvec[i];
@@ -286,6 +287,7 @@ static struct cl_page *cl_page_alloc(const struct lu_env *env,
 			GFP_NOFS);
 	if (page != NULL) {
 		int result = 0;
+
 		atomic_set(&page->cp_ref, 1);
 		if (type == CPT_CACHEABLE) /* for radix tree */
 			atomic_inc(&page->cp_ref);
-- 
1.9.0

Re: [PATCH 1/5] Add blank line under variable declaration.

[Greg KH]

For all of these, you need a better subject line that shows what part of
the kernel you are modifying.

For example, this one would be:
	Subject: [PATCH 1/5] staging: lustre: cl_page.c: add blank line after variable definition


On Thu, Jul 23, 2015 at 02:21:10PM +0800, Incarnation P. Lee wrote:
> Signed-off-by: Incarnation P. Lee <incarnation.p.lee@outlook.com>
> 

We need a changelog entry, it can't be blank.

And I need a hint of "real" name here, is "Incarnation P. Lee" how you
sign legal documents?

thanks,

greg k-h

[PATCH 2/5] Add one space after that ',' in parameters list.

[Incarnation P. Lee]

Signed-off-by: Incarnation P. Lee <incarnation.p.lee@outlook.com>

---
 drivers/staging/lustre/lustre/obdclass/cl_page.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c b/drivers/staging/lustre/lustre/obdclass/cl_page.c
index 8b2c1e7..739814e 100644
--- a/drivers/staging/lustre/lustre/obdclass/cl_page.c
+++ b/drivers/staging/lustre/lustre/obdclass/cl_page.c
@@ -1427,7 +1427,7 @@ void cl_page_clip(const struct lu_env *env, struct cl_page *pg,
 	CL_PAGE_HEADER(D_TRACE, env, pg, "%d %d\n", from, to);
 	CL_PAGE_INVOID(env, pg, CL_PAGE_OP(cpo_clip),
 		       (const struct lu_env *,
-			const struct cl_page_slice *,int, int),
+			const struct cl_page_slice *, int, int),
 		       from, to);
 }
 EXPORT_SYMBOL(cl_page_clip);
-- 
1.9.0

[PATCH 3/5] Remove unnecessary braces {} are for single statement blocks

[Incarnation P. Lee]

Signed-off-by: Incarnation P. Lee <incarnation.p.lee@outlook.com>

---
 drivers/staging/lustre/lustre/obdclass/cl_page.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c b/drivers/staging/lustre/lustre/obdclass/cl_page.c
index 739814e..c386c43 100644
--- a/drivers/staging/lustre/lustre/obdclass/cl_page.c
+++ b/drivers/staging/lustre/lustre/obdclass/cl_page.c
@@ -374,9 +374,8 @@ static struct cl_page *cl_page_find0(const struct lu_env *env,
 						       idx) == page));
 	}
 
-	if (page != NULL) {
+	if (page != NULL)
 		return page;
-	}
 
 	/* allocate and initialize cl_page */
 	page = cl_page_alloc(env, o, idx, vmpage, type);
-- 
1.9.0

[PATCH 4/5] Replace spaces at the start of a line with tab.

[Incarnation P. Lee]

Signed-off-by: Incarnation P. Lee <incarnation.p.lee@outlook.com>

---
 drivers/staging/lustre/lustre/obdclass/cl_page.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c b/drivers/staging/lustre/lustre/obdclass/cl_page.c
index c386c43..4cc17d3 100644
--- a/drivers/staging/lustre/lustre/obdclass/cl_page.c
+++ b/drivers/staging/lustre/lustre/obdclass/cl_page.c
@@ -52,12 +52,12 @@ static void cl_page_delete0(const struct lu_env *env, struct cl_page *pg,
 			    int radix);
 
 # define PASSERT(env, page, expr)				       \
-  do {								    \
+	do {								    \
 	  if (unlikely(!(expr))) {				      \
 		  CL_PAGE_DEBUG(D_ERROR, (env), (page), #expr "\n");    \
 		  LASSERT(0);					   \
 	  }							     \
-  } while (0)
+	} while (0)
 
 # define PINVRNT(env, page, exp) \
 	((void)sizeof(env), (void)sizeof(page), (void)sizeof !!(exp))
-- 
1.9.0

[PATCH 5/5] Adjust code indent for conditional statements with tab.

[Incarnation P. Lee]

Signed-off-by: Incarnation P. Lee <incarnation.p.lee@outlook.com>

---
 drivers/staging/lustre/lustre/obdclass/cl_page.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c b/drivers/staging/lustre/lustre/obdclass/cl_page.c
index 4cc17d3..428c6b2 100644
--- a/drivers/staging/lustre/lustre/obdclass/cl_page.c
+++ b/drivers/staging/lustre/lustre/obdclass/cl_page.c
@@ -51,12 +51,12 @@
 static void cl_page_delete0(const struct lu_env *env, struct cl_page *pg,
 			    int radix);
 
-# define PASSERT(env, page, expr)				       \
-	do {								    \
-	  if (unlikely(!(expr))) {				      \
-		  CL_PAGE_DEBUG(D_ERROR, (env), (page), #expr "\n");    \
-		  LASSERT(0);					   \
-	  }							     \
+# define PASSERT(env, page, expr)					   \
+	do {								   \
+		if (unlikely(!(expr))) {				   \
+			CL_PAGE_DEBUG(D_ERROR, (env), (page), #expr "\n"); \
+			LASSERT(0);					   \
+		}							   \
 	} while (0)
 
 # define PINVRNT(env, page, exp) \
-- 
1.9.0