* [PATCH] soc: versatile: Use devm_kzalloc
@ 2015-07-27 3:23 Vaishali Thakkar
2015-07-28 12:05 ` Linus Walleij
0 siblings, 1 reply; 4+ messages in thread
From: Vaishali Thakkar @ 2015-07-27 3:23 UTC (permalink / raw)
To: Linus Walleij; +Cc: Arnd Bergmann, Paul Gortmaker, Axel Lin, linux-kernel
This patch introduces the use of devm_kzalloc and does away
with kfree in the probe function.
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
---
Some comments on this patch and driver:
- Here, after this change there will be a kfree on the failure of
the regmap_read too. I am not sure if driver is currently missing
it or there is something else happening here. Also, I think there
should be soc_device_unregister under the regmap_read.
- Moreover, get_maintainer.pl is not pointing me towards any particular
mailing list or maintainers. So, I am sending this patch to all
commiters as there are only three commits for this driver.
---
drivers/soc/versatile/soc-realview.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/soc/versatile/soc-realview.c b/drivers/soc/versatile/soc-realview.c
index e642c45..0889710 100644
--- a/drivers/soc/versatile/soc-realview.c
+++ b/drivers/soc/versatile/soc-realview.c
@@ -103,7 +103,8 @@ static int realview_soc_probe(struct platform_device *pdev)
if (IS_ERR(syscon_regmap))
return PTR_ERR(syscon_regmap);
- soc_dev_attr = kzalloc(sizeof(*soc_dev_attr), GFP_KERNEL);
+ soc_dev_attr = devm_kzalloc(&pdev->dev, sizeof(*soc_dev_attr),
+ GFP_KERNEL);
if (!soc_dev_attr)
return -ENOMEM;
@@ -115,10 +116,9 @@ static int realview_soc_probe(struct platform_device *pdev)
soc_dev_attr->machine = "RealView";
soc_dev_attr->family = "Versatile";
soc_dev = soc_device_register(soc_dev_attr);
- if (IS_ERR(soc_dev)) {
- kfree(soc_dev_attr);
+ if (IS_ERR(soc_dev))
return -ENODEV;
- }
+
ret = regmap_read(syscon_regmap, REALVIEW_SYS_ID_OFFSET,
&realview_coreid);
if (ret)
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: versatile: Use devm_kzalloc
2015-07-27 3:23 [PATCH] soc: versatile: Use devm_kzalloc Vaishali Thakkar
@ 2015-07-28 12:05 ` Linus Walleij
[not found] ` <CAK-LDbKW2P3Q-ZPnxu-EkMu+CRp=FxT-4ABrfmpGxonG47HM0A@mail.gmail.com>
0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2015-07-28 12:05 UTC (permalink / raw)
To: Vaishali Thakkar; +Cc: Arnd Bergmann, Paul Gortmaker, Axel Lin, linux-kernel
On Mon, Jul 27, 2015 at 5:23 AM, Vaishali Thakkar
<vthakkar1994@gmail.com> wrote:
> This patch introduces the use of devm_kzalloc and does away
> with kfree in the probe function.
>
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Please get this through ARM SoC or tell me if I should handle it.
> Some comments on this patch and driver:
> - Here, after this change there will be a kfree on the failure of
> the regmap_read too. I am not sure if driver is currently missing
> it or there is something else happening here. Also, I think there
> should be soc_device_unregister under the regmap_read.
Likely. There are sloppy errors everywhere.
> - Moreover, get_maintainer.pl is not pointing me towards any particular
> mailing list or maintainers. So, I am sending this patch to all
> commiters as there are only three commits for this driver.
This is my code, also my stupid bugs :/
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: versatile: Use devm_kzalloc
[not found] ` <CAK-LDbKW2P3Q-ZPnxu-EkMu+CRp=FxT-4ABrfmpGxonG47HM0A@mail.gmail.com>
@ 2015-07-29 8:30 ` Linus Walleij
2015-07-30 2:46 ` Vaishali Thakkar
0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2015-07-29 8:30 UTC (permalink / raw)
To: Vaishali Thakkar; +Cc: Paul Gortmaker, linux-kernel, Axel Lin, Arnd Bergmann
On Tue, Jul 28, 2015 at 4:17 PM, Vaishali Thakkar
<vthakkar1994@gmail.com> wrote:
> On 28 Jul 2015 17:35, "Linus Walleij" <linus.walleij@linaro.org> wrote:
>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>> Please get this through ARM SoC or tell me if I should handle it.
>
> So, do you want me to send this in ARM SoC mailing list?
linux-arm-kernel@lists.infradead.org is preferred, if you want
the ARM SoC maintainers to apply the patch directly not
that it has my Review tag, send it to arm@vger.kernel.org
and ask them to apply it.
>> Likely. There are sloppy errors everywhere.
>
> Can I go for handling them?? I am not sure how much important this driver
> is.
Yes, and it's kind of important-ish since people look at
reference designs when doing other board support and the
realviews are also supported in QEMU making them kind
of popular.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: versatile: Use devm_kzalloc
2015-07-29 8:30 ` Linus Walleij
@ 2015-07-30 2:46 ` Vaishali Thakkar
0 siblings, 0 replies; 4+ messages in thread
From: Vaishali Thakkar @ 2015-07-30 2:46 UTC (permalink / raw)
To: Linus Walleij; +Cc: Paul Gortmaker, linux-kernel, Axel Lin, Arnd Bergmann
On Wed, Jul 29, 2015 at 2:00 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Tue, Jul 28, 2015 at 4:17 PM, Vaishali Thakkar
> <vthakkar1994@gmail.com> wrote:
>> On 28 Jul 2015 17:35, "Linus Walleij" <linus.walleij@linaro.org> wrote:
>
>>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>>> Please get this through ARM SoC or tell me if I should handle it.
>>
>> So, do you want me to send this in ARM SoC mailing list?
>
> linux-arm-kernel@lists.infradead.org is preferred, if you want
> the ARM SoC maintainers to apply the patch directly not
> that it has my Review tag, send it to arm@vger.kernel.org
> and ask them to apply it.
Ok. I will send this to linux-arm-kernel@lists.infradead.org
with your Review tag.
>>> Likely. There are sloppy errors everywhere.
>>
>> Can I go for handling them?? I am not sure how much important this driver
>> is.
>
> Yes, and it's kind of important-ish since people look at
> reference designs when doing other board support and the
> realviews are also supported in QEMU making them kind
> of popular.
I see. Then I'll go for it.
Thank You.
> Yours,
> Linus Walleij
--
Vaishali
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-30 2:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-27 3:23 [PATCH] soc: versatile: Use devm_kzalloc Vaishali Thakkar
2015-07-28 12:05 ` Linus Walleij
[not found] ` <CAK-LDbKW2P3Q-ZPnxu-EkMu+CRp=FxT-4ABrfmpGxonG47HM0A@mail.gmail.com>
2015-07-29 8:30 ` Linus Walleij
2015-07-30 2:46 ` Vaishali Thakkar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®