* [PATCH] ntb: avoid format string in dev_set_name
@ 2015-07-24 23:35 Kees Cook
2015-07-27 19:04 ` Jon Mason
0 siblings, 1 reply; 2+ messages in thread
From: Kees Cook @ 2015-07-24 23:35 UTC (permalink / raw)
To: linux-kernel; +Cc: Jon Mason, Dave Jiang, Allen Hubbe
Avoid any chance of format string expansion when calling dev_set_name.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/ntb/ntb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ntb/ntb.c b/drivers/ntb/ntb.c
index 23435f2a5486..2e2530743831 100644
--- a/drivers/ntb/ntb.c
+++ b/drivers/ntb/ntb.c
@@ -114,7 +114,7 @@ int ntb_register_device(struct ntb_dev *ntb)
ntb->dev.bus = &ntb_bus;
ntb->dev.parent = &ntb->pdev->dev;
ntb->dev.release = ntb_dev_release;
- dev_set_name(&ntb->dev, pci_name(ntb->pdev));
+ dev_set_name(&ntb->dev, "%s", pci_name(ntb->pdev));
ntb->ctx = NULL;
ntb->ctx_ops = NULL;
--
1.9.1
--
Kees Cook
Chrome OS Security
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ntb: avoid format string in dev_set_name
2015-07-24 23:35 [PATCH] ntb: avoid format string in dev_set_name Kees Cook
@ 2015-07-27 19:04 ` Jon Mason
0 siblings, 0 replies; 2+ messages in thread
From: Jon Mason @ 2015-07-27 19:04 UTC (permalink / raw)
To: Kees Cook; +Cc: linux-kernel, Dave Jiang, Allen Hubbe
On Fri, Jul 24, 2015 at 04:35:59PM -0700, Kees Cook wrote:
> Avoid any chance of format string expansion when calling dev_set_name.
Looks good to me. I'll pull it into my next release.
Thanks,
Jon
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> drivers/ntb/ntb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ntb/ntb.c b/drivers/ntb/ntb.c
> index 23435f2a5486..2e2530743831 100644
> --- a/drivers/ntb/ntb.c
> +++ b/drivers/ntb/ntb.c
> @@ -114,7 +114,7 @@ int ntb_register_device(struct ntb_dev *ntb)
> ntb->dev.bus = &ntb_bus;
> ntb->dev.parent = &ntb->pdev->dev;
> ntb->dev.release = ntb_dev_release;
> - dev_set_name(&ntb->dev, pci_name(ntb->pdev));
> + dev_set_name(&ntb->dev, "%s", pci_name(ntb->pdev));
>
> ntb->ctx = NULL;
> ntb->ctx_ops = NULL;
> --
> 1.9.1
>
>
> --
> Kees Cook
> Chrome OS Security
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-27 19:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-24 23:35 [PATCH] ntb: avoid format string in dev_set_name Kees Cook
2015-07-27 19:04 ` Jon Mason
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®