From: Jiri Olsa <jolsa@redhat.com>
To: kan.liang@intel.com
Cc: a.p.zijlstra@chello.nl, acme@kernel.org, luto@kernel.org,
mingo@redhat.com, eranian@google.com, ak@linux.intel.com,
mark.rutland@arm.com, adrian.hunter@intel.com, jolsa@kernel.org,
namhyung@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 5/5] perf,tools: Show freq/CPU%/CORE_BUSY% in perf report --stdio
Date: Wed, 29 Jul 2015 15:22:57 +0200 [thread overview]
Message-ID: <20150729132256.GK9606@krava.brq.redhat.com> (raw)
In-Reply-To: <1438082975-47730-6-git-send-email-kan.liang@intel.com>
On Tue, Jul 28, 2015 at 07:29:35AM -0400, kan.liang@intel.com wrote:
SNIP
> #undef DIM
> diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h
> index b98ce51..467ecc4 100644
> --- a/tools/perf/util/symbol.h
> +++ b/tools/perf/util/symbol.h
> @@ -80,6 +80,14 @@ static inline size_t symbol__size(const struct symbol *sym)
> struct strlist;
> struct intlist;
>
> +enum freq_perf_type_index {
> + DISPLAY_FREQ = 0,
> + DISPLAY_CPU_UTIL,
> + DISPLAY_CORE_BUSY,
> +
> + DISPLAY_MAX
> +};
> +
> struct symbol_conf {
> unsigned short priv_size;
> unsigned short nr_events;
> @@ -106,7 +114,9 @@ struct symbol_conf {
> filter_relative,
> show_hist_headers,
> branch_callstack,
> - has_filter;
> + has_filter,
> + show_freq_perf,
> + freq_perf_type[DISPLAY_MAX];
IMO bitmask of 'enum freq_perf_type_index' would be better
jirka
prev parent reply other threads:[~2015-07-29 13:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 11:29 [PATCH V3 0/5] Freq/CPU%/CORE_BUSY% support kan.liang
2015-07-28 11:29 ` [PATCH V3 1/5] perf,tools: introduce generic FEAT for CPU attributes kan.liang
2015-07-29 12:31 ` Jiri Olsa
2015-07-28 11:29 ` [PATCH V3 2/5] perf,tools: read msr pmu type from header kan.liang
2015-07-28 11:29 ` [PATCH V3 3/5] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY% in report -D kan.liang
2015-07-29 12:52 ` Jiri Olsa
2015-07-29 15:12 ` Arnaldo Carvalho de Melo
2015-07-29 12:53 ` Jiri Olsa
2015-07-29 15:43 ` Arnaldo Carvalho de Melo
2015-07-29 16:12 ` Arnaldo Carvalho de Melo
2015-08-04 17:07 ` Liang, Kan
2015-08-04 17:53 ` Arnaldo Carvalho de Melo
2015-07-29 13:13 ` Jiri Olsa
2015-07-29 13:14 ` Jiri Olsa
2015-07-28 11:29 ` [PATCH V3 4/5] perf,tools: caculate and save freq/CPU%/CORE_BUSY% in he_stat kan.liang
2015-07-28 11:29 ` [PATCH V3 5/5] perf,tools: Show freq/CPU%/CORE_BUSY% in perf report --stdio kan.liang
2015-07-29 13:22 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150729132256.GK9606@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®