mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: NeilBrown <neil@brown.name>
To: jake42 <jake42@rommel.stw.uni-erlangen.de>
Cc: Sebastian Reichel <sre@kernel.org>, <linux-api@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <inux-pm@vger.kernel.org>,
	Pavel Machek <pavel@ucw.cz>, <linux-omap@vger.kernel.org>,
	Lee Jones <lee.jones@linaro.org>,
	List for communicating with real GTA04 owners 
	<gta04-owner@goldelico.com>
Subject: Re: [Gta04-owner] [PATCH 08/14] twl4030_charger: allow max_current to be managed via sysfs.
Date: Thu, 30 Jul 2015 08:10:46 +1000	[thread overview]
Message-ID: <20150730081046.027ba82e@home.neil.brown.name> (raw)
In-Reply-To: <a05a88a7a3ea4519ada7216ab5bfe097@rommel.stw.uni-erlangen.de>

On Mon, 23 Mar 2015 13:14:50 +0100 jake42
<jake42@rommel.stw.uni-erlangen.de> wrote:

> Hello Neil,
> 
> some suggestions:
> 
> On 23.03.2015 00:20, NeilBrown wrote:
> > From: NeilBrown <neilb@suse.de>
> > diff --git a/Documentation/ABI/testing/sysfs-class-power-twl4030
> > b/Documentation/ABI/testing/sysfs-class-power-twl4030
> > new file mode 100644
> > index 000000000000..06092209d851
> > --- /dev/null
> > +++ b/Documentation/ABI/testing/sysfs-class-power-twl4030
> > @@ -0,0 +1,15 @@
> > +What: /sys/class/power_supply/twl4030_ac/max_current
> > +      /sys/class/power_supply/twl4030_usb/max_current
> > +Description:
> > +	Read/Write limit on current which which may
> one less which                        ^^
> > +	be drawn from the ac (Accessory Charger) or
> > +	USB port.
> > +
> > +	Value is in micro-Amps.
> > +
> > +	Value is set automatically to an appropriate
> > +	value when a cable is plugged on unplugged.
> s/on/or                               ^^
> > +
> > +	Value can the set by writing to the attribute.
>                    ^^ be set?
> > +	The change will only persist until the next
> > +	plug event.  These event are reported via udev.
> 
> Regards
> Jake
> 

Thanks.
I've made those two changes.

NeilBrown

  reply	other threads:[~2015-07-29 22:28 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-22 23:20 [PATCH 00/14] Enhance twl4030_charger functionality. - V2 NeilBrown
2015-03-22 23:20 ` [PATCH 04/14] twl4030_charger: trust phy to determine when USB power is available NeilBrown
2015-03-22 23:20 ` [PATCH 01/14] twl4030_charger: use devm_request_threaded_irq NeilBrown
2015-07-24 14:34   ` Sebastian Reichel
2015-03-22 23:20 ` [PATCH 02/14] twl4030_charger: use devres for power_supply_register and kzalloc NeilBrown
2015-03-23 21:25   ` Pavel Machek
2015-07-24 14:35   ` Sebastian Reichel
2015-03-22 23:20 ` [PATCH 03/14] twl4030_charger: use runtime_pm to keep usb phy active while charging NeilBrown
2015-03-22 23:20 ` [PATCH 05/14] twl4030_charger: split uA calculation into a function NeilBrown
2015-03-22 23:20 ` [PATCH 14/14] twl4030_charger: assume a 'charger' can supply maximum current NeilBrown
2015-03-22 23:20 ` [PATCH 13/14] twl4030_charger: Increase current carefully while watching voltage NeilBrown
2015-03-23 21:25   ` Pavel Machek
2015-03-29 21:26     ` NeilBrown
2015-04-04  7:48       ` Pavel Machek
2015-03-22 23:20 ` [PATCH 11/14] twl4030_charger: add software controlled linear charging mode NeilBrown
2015-03-22 23:20 ` [PATCH 07/14] twl4030_charger: distinguish between USB current and 'AC' current NeilBrown
2015-03-22 23:20 ` [PATCH 06/14] twl4030_charger: allow fine control of charger current NeilBrown
2015-03-22 23:20 ` [PATCH 12/14] twl4030_charger: add ac/mode to match usb/mode NeilBrown
2015-03-22 23:20 ` [PATCH 08/14] twl4030_charger: allow max_current to be managed via sysfs NeilBrown
2015-03-23 12:14   ` [Gta04-owner] " jake42
2015-07-29 22:10     ` NeilBrown [this message]
2015-03-22 23:20 ` [PATCH 09/14] twl4030_charger: only draw USB current as negotiated with host NeilBrown
2015-03-22 23:20 ` [PATCH 10/14] twl4030_charger: enable manual enable/disable of usb charging NeilBrown
2015-07-24 14:44 ` [PATCH 00/14] Enhance twl4030_charger functionality. - V2 Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150730081046.027ba82e@home.neil.brown.name \
    --to=neil@brown.name \
    --cc=gta04-owner@goldelico.com \
    --cc=inux-pm@vger.kernel.org \
    --cc=jake42@rommel.stw.uni-erlangen.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®