From: Peter Zijlstra <peterz@infradead.org>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Andrey Konovalov <andreyknvl@google.com>,
Ingo Molnar <mingo@kernel.org>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] compiler.h: cast away attributes in WRITE_ONCE magic
Date: Tue, 4 Aug 2015 12:47:23 +0200 [thread overview]
Message-ID: <20150804104723.GP25159@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <55C094E0.7020406@de.ibm.com>
On Tue, Aug 04, 2015 at 12:33:04PM +0200, Christian Borntraeger wrote:
> Am 04.08.2015 um 11:20 schrieb Peter Zijlstra:
> > On Tue, Aug 04, 2015 at 09:55:48AM +0200, Christian Borntraeger wrote:
> >> kernel build bot showed a warning triggered by commit
> >> 76695af20c01 ("locking, arch: use WRITE_ONCE()/READ_ONCE() in
> >> smp_store_release()/smp_load_acquire()"). Turns out that sparse
> >> does not like WRITE_ONCE accessing elements from the (sparse)
> >> rcu address space.
> >>
> >> fs/afs/inode.c:448:9: sparse: incorrect type in initializer (different address spaces)
> >> fs/afs/inode.c:448:9: expected struct afs_permits *__val
> >> fs/afs/inode.c:448:9: got void [noderef] <asn:4>*<noident>
> >>
> >> Solution is to force cast away the sparse attributes for the initializer
> >> of the union in WRITE_SAME. As this now gets too long, lets split
> >
> > WRITE_ONCE, right?
>
> Indeed, guess what area I was looking into before....;-)
>
> Shall I respin or can you fixup.
I've already fixed it. Thanks!
next prev parent reply other threads:[~2015-08-04 10:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 7:55 [PATCH] Fixup for WRITE_ONCE vs. sparse Christian Borntraeger
2015-08-04 7:55 ` [PATCH] compiler.h: cast away attributes in WRITE_ONCE magic Christian Borntraeger
2015-08-04 9:20 ` Peter Zijlstra
2015-08-04 10:33 ` Christian Borntraeger
2015-08-04 10:47 ` Peter Zijlstra [this message]
2015-08-12 12:34 ` [tip:locking/core] locking, compiler.h: Cast away attributes in the WRITE_ONCE() magic tip-bot for Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804104723.GP25159@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=andreyknvl@google.com \
--cc=borntraeger@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome