mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] fallback to hostname in scripts/package/builddeb
@ 2015-08-03  3:03 Christian Kujau
  2015-08-04 11:43 ` Michal Marek
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Kujau @ 2015-08-03  3:03 UTC (permalink / raw)
  To: Michal Marek; +Cc: linux-kernel

Hi,

I happened to build a kernel with "make deb-pkg" on a machine with no 
network connectivity, but this failed with:

[...]
  INSTALL debian/headertmp/usr/include/asm/ (65 files)
hostname: Name or service not known
../scripts/package/Makefile:90: recipe for target 'deb-pkg' failed
make[2]: *** [deb-pkg] Error 1

In scripts/package/builddeb it tries to construct an email address (that 
can be queried in /proc/version later on) but with no network, 
the "hostname -f" fails. The following patch falls back to just use the 
shortname if we cannot determine our FQDN.

Signed-off-by: Christian Kujau <lists@nerdbynature.de>

diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index 88dbf23..7de1d1c 100755
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -206,7 +206,7 @@ if [ -n "$DEBEMAIL" ]; then
 elif [ -n "$EMAIL" ]; then
        email=$EMAIL
 else
-       email=$(id -nu)@$(hostname -f)
+       email=$(id -nu)@$(hostname -f 2>/dev/null || hostname)
 fi
 if [ -n "$DEBFULLNAME" ]; then
        name=$DEBFULLNAME


-- 
BOFH excuse #334:

50% of the manual is in .pdf readme files

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fallback to hostname in scripts/package/builddeb
  2015-08-03  3:03 [PATCH] fallback to hostname in scripts/package/builddeb Christian Kujau
@ 2015-08-04 11:43 ` Michal Marek
  0 siblings, 0 replies; 2+ messages in thread
From: Michal Marek @ 2015-08-04 11:43 UTC (permalink / raw)
  To: Christian Kujau; +Cc: linux-kernel

On Sun, Aug 02, 2015 at 08:03:26PM -0700, Christian Kujau wrote:
> Hi,
> 
> I happened to build a kernel with "make deb-pkg" on a machine with no 
> network connectivity, but this failed with:
> 
> [...]
>   INSTALL debian/headertmp/usr/include/asm/ (65 files)
> hostname: Name or service not known
> ../scripts/package/Makefile:90: recipe for target 'deb-pkg' failed
> make[2]: *** [deb-pkg] Error 1
> 
> In scripts/package/builddeb it tries to construct an email address (that 
> can be queried in /proc/version later on) but with no network, 
> the "hostname -f" fails. The following patch falls back to just use the 
> shortname if we cannot determine our FQDN.
> 
> Signed-off-by: Christian Kujau <lists@nerdbynature.de>

Applied to kbuild.git#misc, thanks.

Michal

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-08-04 11:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-03  3:03 [PATCH] fallback to hostname in scripts/package/builddeb Christian Kujau
2015-08-04 11:43 ` Michal Marek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®