From: Chandra Gorentla <csgorentla@gmail.com>
To: gregkh@linuxfoundation.org
Cc: johnny.kim@atmel.com, rachel.kim@atmel.com, dean.lee@atmel.com,
chris.park@atmel.com, linux-wireless@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Chandra S Gorentla <csgorentla@gmail.com>
Subject: Re: [PATCH v3 2/3] drivers: staging: wilc1000: move { to previous line
Date: Thu, 6 Aug 2015 21:29:44 +0530 [thread overview]
Message-ID: <20150806155939.GA18397@gcs-HP-Compaq-nx6320> (raw)
In-Reply-To: <1438792917-9817-3-git-send-email-csgorentla@gmail.com>
On Wed, Aug 05, 2015 at 10:11:56PM +0530, Chandra S Gorentla wrote:
> Moved the opening brace of code blocks to the previous lines. This
> fixes the checkpatch.pl error - "that open brace { should be on the
> previous line".
>
> Signed-off-by: Chandra S Gorentla <csgorentla@gmail.com>
> ---
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> index c2ef46f..779ec5a 100644
> --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> @@ -1205,8 +1205,7 @@ static int WILC_WFI_add_key(struct wiphy *wiphy, struct net_device *netdev, u8 k
>
>
>
> - if (!pairwise)
> - {
> + if (!pairwise) {
> if (params->cipher == WLAN_CIPHER_SUITE_TKIP)
> u8gmode = ENCRYPT_ENABLED | WPA | TKIP;
> else
> @@ -1304,8 +1303,7 @@ static int WILC_WFI_add_key(struct wiphy *wiphy, struct net_device *netdev, u8 k
>
> {
> u8mode = 0;
> - if (!pairwise)
> - {
> + if (!pairwise) {
> if (params->key_len > 16 && params->cipher == WLAN_CIPHER_SUITE_TKIP) {
> /* swap the tx mic by rx mic */
> pu8RxMic = params->key + 24;
> @@ -1531,8 +1529,7 @@ static int WILC_WFI_get_key(struct wiphy *wiphy, struct net_device *netdev, u8 k
> priv = wiphy_priv(wiphy);
>
>
> - if (!pairwise)
> - {
> + if (!pairwise) {
> PRINT_D(CFG80211_DBG, "Getting group key idx: %x\n", key_index);
>
> key_params.key = priv->wilc_gtk[key_index]->key;
> --
> 2.5.0
>
Hello Greg,
I sent 3 patches in this series. The subject lines of other 2 are -
[PATCH v3 3/3] drivers: staging: wilc1000: remove space after '('
[PATCH v3 1/3] drivers: staging: wilc1000: use 'void' for no arguments
functions
These two patches (1/3 and 3/3) were accepted but not the patch (2/3) in this
mail. Any reason for not accepting? Is any thing wrong with this patch - 2/3?
If so, I can correct and send again.
Thanks,
chandra
next prev parent reply other threads:[~2015-08-06 16:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 16:41 [PATCH v3 0/3] drivers: staging: wilc1000: Fix a few style errors Chandra S Gorentla
2015-08-05 16:41 ` [PATCH v3 1/3] drivers: staging: wilc1000: use 'void' for no arguments functions Chandra S Gorentla
2015-08-05 16:41 ` [PATCH v3 2/3] drivers: staging: wilc1000: move { to previous line Chandra S Gorentla
2015-08-05 16:41 ` [PATCH v3 3/3] drivers: staging: wilc1000: remove space after '(' Chandra S Gorentla
2015-08-06 15:59 ` Chandra Gorentla [this message]
2015-08-06 16:55 ` [PATCH v3 2/3] drivers: staging: wilc1000: move { to previous line Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150806155939.GA18397@gcs-HP-Compaq-nx6320 \
--to=csgorentla@gmail.com \
--cc=chris.park@atmel.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®