Re: [PATCH] regulator: da9063: Add set_voltage_time_sel function

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 825 bytes --]

On Thu, Aug 06, 2015 at 06:38:24PM +0200, Philipp Zabel wrote:
> This allows to set the regulator-ramp-delay in the device tree.

> @@ -433,6 +433,7 @@ static struct regulator_ops da9063_buck_ops = {
>  	.is_enabled		= regulator_is_enabled_regmap,
>  	.get_voltage_sel	= regulator_get_voltage_sel_regmap,
>  	.set_voltage_sel	= regulator_set_voltage_sel_regmap,
> +	.set_voltage_time_sel	= regulator_set_voltage_time_sel,
>  	.list_voltage		= regulator_list_voltage_linear,
>  	.set_current_limit	= da9063_set_current_limit,
>  	.get_current_limit	= da9063_get_current_limit,

This doesn't seem right - we shouldn't need to manually add this to
every device to get the generic property to work.  Instead we ought to
just do this by default if there's nothing defined in the driver and we
see that a value was provided by DT.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]