mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: ebiederm@xmission.com, vgoyal@redhat.com, dyoung@redhat.com,
	mhuang@redhat.com, lisa.mitchell@hp.com, tatsu@ab.jp.nec.com,
	seiji.aguchi.tr@hitachi.com, linux-kernel@vger.kernel.org,
	kexec@lists.infradead.org
Subject: Re: [Patch v2] align crash_notes allocation to make it be inside one physical page
Date: Tue, 11 Aug 2015 14:33:33 +0800	[thread overview]
Message-ID: <20150811063333.GB9748@dhcp-17-102.nay.redhat.com> (raw)
In-Reply-To: <20150803150417.b3536887b1ad86ae04c405b7@linux-foundation.org>

Hi Andrew,

On 08/03/15 at 03:04pm, Andrew Morton wrote:
> On Mon,  3 Aug 2015 20:50:43 +0800 Baoquan He <bhe@redhat.com> wrote:
> And I think the WARN_ON can be replaced with a
> BUILD_BUG_ON(sizeof>PAGE_SIZE)?  That would avoid adding runtime
> overhead.

Rethink about this, you are right. Using BUILD_BUG_ON is better.
Anyone who found this compiling break should check if his/her code
changes increase the crash_notes size. If possible that increase need be
avoidable. Otherwise he should report this to upstream why it's
unavoidable to increase crash_notes size, then let's consider the
redesign the crash_notes data structure. 

So I will use BUILD_BUG_ON and repost.

Thanks
Baoquan
> 

  parent reply	other threads:[~2015-08-11  6:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-03 12:50 Baoquan He
2015-08-03 22:04 ` Andrew Morton
2015-08-03 23:01   ` Baoquan He
2015-08-11  6:33   ` Baoquan He [this message]
2015-08-11  8:01     ` Minfei Huang
2015-08-11  8:42       ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150811063333.GB9748@dhcp-17-102.nay.redhat.com \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dyoung@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lisa.mitchell@hp.com \
    --cc=mhuang@redhat.com \
    --cc=seiji.aguchi.tr@hitachi.com \
    --cc=tatsu@ab.jp.nec.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®