From: Baoquan He <bhe@redhat.com>
To: Minfei Huang <mhuang@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
ebiederm@xmission.com, vgoyal@redhat.com, dyoung@redhat.com,
lisa.mitchell@hp.com, tatsu@ab.jp.nec.com,
seiji.aguchi.tr@hitachi.com, linux-kernel@vger.kernel.org,
kexec@lists.infradead.org
Subject: Re: [Patch v2] align crash_notes allocation to make it be inside one physical page
Date: Tue, 11 Aug 2015 16:42:12 +0800 [thread overview]
Message-ID: <20150811084212.GD9748@dhcp-17-102.nay.redhat.com> (raw)
In-Reply-To: <20150811080108.GA2404@dhcp-128-25.nay.redhat.com>
Hi,
On 08/11/15 at 04:01pm, Minfei Huang wrote:
> Baoquan.
>
> If the size of notes never be exceeded to PAGE_SIZE, I think we can
> revert below patch, since the situation which describes in patch does
> not happen.
>
> commit 38dfac843cb6d7be1874888839817404a15a6b3c
> Author: Greg Pearson <greg.pearson@hp.com>
> Date: Mon Feb 10 14:25:36 2014 -0800
>
> vmcore: prevent PT_NOTE p_memsz overflow during header update
>
> What do you think about this?
Yeah, I am fine with this reverting. If people all agree with this I can
post patch to revert this. In fact I am eagerer to revert below commit
since it's a littble bit confusing after crash_notes crossing 2
pages bug is fixed. Below commit is a work around fix , but it's too much.
I am willing to hear people's idea.
commit 34b47764297130b21aaeb4cc6119bb811814b8e3
Author: WANG Chao <chaowang@redhat.com>
Date: Tue Feb 17 13:46:01 2015 -0800
vmcore: fix PT_NOTE n_namesz, n_descsz overflow issue
Thanks
Baoquan
prev parent reply other threads:[~2015-08-11 8:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 12:50 Baoquan He
2015-08-03 22:04 ` Andrew Morton
2015-08-03 23:01 ` Baoquan He
2015-08-11 6:33 ` Baoquan He
2015-08-11 8:01 ` Minfei Huang
2015-08-11 8:42 ` Baoquan He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150811084212.GD9748@dhcp-17-102.nay.redhat.com \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lisa.mitchell@hp.com \
--cc=mhuang@redhat.com \
--cc=seiji.aguchi.tr@hitachi.com \
--cc=tatsu@ab.jp.nec.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®