From: Kees Cook <keescook@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] fs-create-and-use-seq_show_option-for-escaping-fix2
Date: Tue, 11 Aug 2015 16:04:01 -0700 [thread overview]
Message-ID: <20150811230401.GA9072@www.outflux.net> (raw)
The buildbots noticed seq_show_option should be using const parameters.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
include/linux/seq_file.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/seq_file.h b/include/linux/seq_file.h
index ff4c631348dd..d4c7271382cb 100644
--- a/include/linux/seq_file.h
+++ b/include/linux/seq_file.h
@@ -155,7 +155,8 @@ static inline struct user_namespace *seq_user_ns(struct seq_file *seq)
* @name: the mount option name
* @value: the mount option name's value, can be NULL
*/
-static inline void seq_show_option(struct seq_file *m, char *name, char *value)
+static inline void seq_show_option(struct seq_file *m, const char *name,
+ const char *value)
{
seq_putc(m, ',');
seq_escape(m, name, ",= \t\n\\");
--
1.9.1
--
Kees Cook
Chrome OS Security
reply other threads:[~2015-08-11 23:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150811230401.GA9072@www.outflux.net \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®