* Re: [tip:perf/core] perf: Fix PERF_EVENT_IOC_PERIOD migration race
[not found] <tip-c7999c6f3fed9e383d3131474588f282ae6d56b9@git.kernel.org>
@ 2015-08-12 13:49 ` Vince Weaver
2015-08-12 17:07 ` Peter Zijlstra
0 siblings, 1 reply; 2+ messages in thread
From: Vince Weaver @ 2015-08-12 13:49 UTC (permalink / raw)
To: mingo, tglx, linux-kernel, hpa, torvalds, peterz; +Cc: linux-tip-commits
On Wed, 12 Aug 2015, tip-bot for Peter Zijlstra wrote:
> Commit-ID: c7999c6f3fed9e383d3131474588f282ae6d56b9
> Gitweb: http://git.kernel.org/tip/c7999c6f3fed9e383d3131474588f282ae6d56b9
> Author: Peter Zijlstra <peterz@infradead.org>
> AuthorDate: Tue, 4 Aug 2015 19:22:49 +0200
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Wed, 12 Aug 2015 11:37:22 +0200
>
> perf: Fix PERF_EVENT_IOC_PERIOD migration race
>
> I ran the perf fuzzer, which triggered some WARN()s which are due to
> trying to stop/restart an event on the wrong CPU.
Do you have a list of which WARNs this should fix? Just so I can
update my bug tracker.
Thanks,
Vince
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [tip:perf/core] perf: Fix PERF_EVENT_IOC_PERIOD migration race
2015-08-12 13:49 ` [tip:perf/core] perf: Fix PERF_EVENT_IOC_PERIOD migration race Vince Weaver
@ 2015-08-12 17:07 ` Peter Zijlstra
0 siblings, 0 replies; 2+ messages in thread
From: Peter Zijlstra @ 2015-08-12 17:07 UTC (permalink / raw)
To: Vince Weaver; +Cc: mingo, tglx, linux-kernel, hpa, torvalds, linux-tip-commits
On Wed, Aug 12, 2015 at 09:49:40AM -0400, Vince Weaver wrote:
> On Wed, 12 Aug 2015, tip-bot for Peter Zijlstra wrote:
>
> > Commit-ID: c7999c6f3fed9e383d3131474588f282ae6d56b9
> > Gitweb: http://git.kernel.org/tip/c7999c6f3fed9e383d3131474588f282ae6d56b9
> > Author: Peter Zijlstra <peterz@infradead.org>
> > AuthorDate: Tue, 4 Aug 2015 19:22:49 +0200
> > Committer: Ingo Molnar <mingo@kernel.org>
> > CommitDate: Wed, 12 Aug 2015 11:37:22 +0200
> >
> > perf: Fix PERF_EVENT_IOC_PERIOD migration race
> >
> > I ran the perf fuzzer, which triggered some WARN()s which are due to
> > trying to stop/restart an event on the wrong CPU.
>
> Do you have a list of which WARNs this should fix? Just so I can
> update my bug tracker.
I think this triggered:
arch/x86/kernel/cpu/perf_event.c:x86_pmu_del()
if (WARN_ON_ONCE(i == cpuc->n_events)) /* called ->del() without ->add() ? */
Through perf_ioctl()->perf_event_period().
I didn't safe a copy of the exact backtrace.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-12 17:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <tip-c7999c6f3fed9e383d3131474588f282ae6d56b9@git.kernel.org>
2015-08-12 13:49 ` [tip:perf/core] perf: Fix PERF_EVENT_IOC_PERIOD migration race Vince Weaver
2015-08-12 17:07 ` Peter Zijlstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome