mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrey Shvetsov <andrey.shvetsov.ml@gmail.com>
To: Tomas Melin <tomas.melin@iki.fi>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/most: fix return value for DIM_GetChannelState
Date: Fri, 14 Aug 2015 10:16:17 +0200	[thread overview]
Message-ID: <20150814081617.GA4158@arch.fritz.box> (raw)
In-Reply-To: <1439129321-27130-1-git-send-email-tomas.melin@iki.fi>

On Sun, Aug 09, 2015 at 05:08:41PM +0300, Tomas Melin wrote:
> Return NULL instead of 0 for invalid input.
> 
> Signed-off-by: Tomas Melin <tomas.melin@iki.fi>
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
> ---
>  drivers/staging/most/hdm-dim2/dim2_hal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/most/hdm-dim2/dim2_hal.c b/drivers/staging/most/hdm-dim2/dim2_hal.c
> index 01b7489..a54cf2c 100644
> --- a/drivers/staging/most/hdm-dim2/dim2_hal.c
> +++ b/drivers/staging/most/hdm-dim2/dim2_hal.c
> @@ -889,7 +889,7 @@ struct dim_ch_state_t *DIM_GetChannelState(struct dim_channel *ch,
>  		struct dim_ch_state_t *state_ptr)
>  {
>  	if (!ch || !state_ptr)
> -		return 0;
> +		return NULL;
>  
>  	state_ptr->ready = ch->state.level < 2;
>  	state_ptr->done_buffers = ch->done_sw_buffers_number;
> -- 
> 1.9.1
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

           reply	other threads:[~2015-08-14  8:16 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1439129321-27130-1-git-send-email-tomas.melin@iki.fi>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150814081617.GA4158@arch.fritz.box \
    --to=andrey.shvetsov.ml@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tomas.melin@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®