From: Mark Brown <broonie@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linaro-kernel@lists.linaro.org, sboyd@codeaurora.org, nm@ti.com,
Liam Girdwood <lgirdwood@gmail.com>,
"open list:VOLTAGE AND CURRENT REGULATOR FRAMEWORK"
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: core: Define regulator_set_voltage_triplet()
Date: Fri, 14 Aug 2015 17:25:06 +0100 [thread overview]
Message-ID: <20150814162506.GV10748@sirena.org.uk> (raw)
In-Reply-To: <28971ff9b110d18970fcc6291531f617cda18230.1439553400.git.viresh.kumar@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 978 bytes --]
On Fri, Aug 14, 2015 at 05:30:55PM +0530, Viresh Kumar wrote:
> The OPP (Operating performance points) v2 bindings allows regulator
> voltage to be supplied as a triplet of <target min max> voltages.
Looking at this I really don't understand why you tried to get me to
review this via an IRC pastebin instead of following the normal patch
submission process. Please don't do that, it's not at all helpful. IRC
can be useful for interactive discussions or things that are really
urgent, not for normal upstream code review.
> +static inline int regulator_set_voltage_triplet(struct regulator *regulator,
> + int target_uV, int min_uV,
> + int max_uV)
This seems awkward, these things are normally written as min <= target
<= max but this is target, min, max.
> static inline int regulator_set_voltage_tol(struct regulator *regulator,
> int new_uV, int tol_uV)
> {
> --
> 2.4.0
You've not added a stub for the new function.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-08-15 2:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 12:00 Viresh Kumar
2015-08-14 16:25 ` Mark Brown [this message]
2015-08-15 3:11 ` Viresh Kumar
2015-08-15 14:08 ` Mark Brown
2015-08-17 2:19 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150814162506.GV10748@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=sboyd@codeaurora.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®