From: Ioan-Adrian Ratiu <adi@adirat.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: andreas.dilger@intel.com, HPDD-discuss@ml01.01.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: lustre: ptlrpc: add missing include directive
Date: Sat, 15 Aug 2015 11:13:39 +0300 [thread overview]
Message-ID: <20150815111339.6a9f7c34@adipc> (raw)
In-Reply-To: <20150815015024.GB19664@kroah.com>
On Fri, 14 Aug 2015 18:50:24 -0700
Greg KH <gregkh@linuxfoundation.org> wrote:
> On Fri, Aug 14, 2015 at 12:57:06PM +0300, Ioan-Adrian Ratiu wrote:
> > Without including ptlrpc_internal.h, GCC gives prototype warnings
> > "pack_generic.c:642:5: warning: no previous prototype for ..."
>
> It does? What version of gcc give you that, I don't see that here.
>
Yes, but it's a non-default warning (-Wmissing-prototypes)
$ gcc --version
gcc (Gentoo 4.9.3 p1.0, pie-0.6.2) 4.9.3
When testing the above patch I've used Ubuntu Vivid Vervet's gcc
(also 4.9 I think, I don't have access to that machine right now).
To see the warn I'm adding "ccflags-y := -Wmissing-prototypes"
to a Makefile then "make SUBDIRS=..."
next prev parent reply other threads:[~2015-08-15 8:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 9:57 Ioan-Adrian Ratiu
2015-08-15 1:50 ` Greg KH
2015-08-15 8:13 ` Ioan-Adrian Ratiu [this message]
2015-08-15 10:11 ` [HPDD-discuss] " Drokin, Oleg
2015-08-15 16:11 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150815111339.6a9f7c34@adipc \
--to=adi@adirat.com \
--cc=HPDD-discuss@ml01.01.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®