mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ioan-Adrian Ratiu <adi@adirat.com>
Cc: andreas.dilger@intel.com, HPDD-discuss@ml01.01.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: lustre: ptlrpc: add missing include directive
Date: Sat, 15 Aug 2015 09:11:36 -0700	[thread overview]
Message-ID: <20150815161136.GA25644@kroah.com> (raw)
In-Reply-To: <20150815111339.6a9f7c34@adipc>

On Sat, Aug 15, 2015 at 11:13:39AM +0300, Ioan-Adrian Ratiu wrote:
> On Fri, 14 Aug 2015 18:50:24 -0700
> Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> > On Fri, Aug 14, 2015 at 12:57:06PM +0300, Ioan-Adrian Ratiu wrote:
> > > Without including ptlrpc_internal.h, GCC gives prototype warnings
> > > "pack_generic.c:642:5: warning: no previous prototype for ..."
> > 
> > It does?  What version of gcc give you that, I don't see that here.
> > 
> 
> Yes, but it's a non-default warning (-Wmissing-prototypes)

Then you should say that, otherwise you have us worrying something is
really wrong with our build/compiler versions...

I've taken this patch, but next time please be more specific.

thanks,

greg k-h

      parent reply	other threads:[~2015-08-15 16:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-14  9:57 Ioan-Adrian Ratiu
2015-08-15  1:50 ` Greg KH
2015-08-15  8:13   ` Ioan-Adrian Ratiu
2015-08-15 10:11     ` [HPDD-discuss] " Drokin, Oleg
2015-08-15 16:11     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150815161136.GA25644@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=HPDD-discuss@ml01.01.org \
    --cc=adi@adirat.com \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome