From: David Miller <davem@davemloft.net>
To: noamc@ezchip.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Alexey.Brodkin@synopsys.com, vgupta@synopsys.com,
talz@ezchip.com
Subject: Re: [v1 0/6] *** nps_enet fixups ***
Date: Mon, 17 Aug 2015 22:26:20 -0700 (PDT) [thread overview]
Message-ID: <20150817.222620.475853456939322841.davem@davemloft.net> (raw)
In-Reply-To: <DB4PR02MB2725A45B664C42E3AB7B98ED6780@DB4PR02MB272.eurprd02.prod.outlook.com>
From: Noam Camus <noamc@ezchip.com>
Date: Tue, 18 Aug 2015 05:04:20 +0000
> I followed "Hardware Architecture" section from:
> http://www.linuxfoundation.org/collaborate/workgroups/networking/napi
> and came up with "reduce processing latency" idea.
That document has lots of incorrect advice, that's for sure.
For one thing, it also says to count TX work against the budget, you
absolutely should not do this. TX work is "free" compared to RX work
(which is several orders of magnitude more expensive) and therefore
should not count against the NAPI budget value.
next prev parent reply other threads:[~2015-08-18 5:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 5:58 Noam Camus
2015-08-17 5:58 ` [v1 1/6] NET: nps_enet: replace use of cause register Noam Camus
2015-08-17 5:58 ` [v1 2/6] NET: nps_enet: reduce processing latency Noam Camus
2015-08-17 5:58 ` [v1 3/6] NET: nps_enet: TX done race condition Noam Camus
2015-08-17 5:58 ` [v1 4/6] NET: nps_enet: drop control frames Noam Camus
2015-08-17 5:58 ` [v1 5/6] NET: nps_enet: TX done acknowledge Noam Camus
2015-08-17 5:58 ` [v1 6/6] NET: nps_enet: minor namespace cleanup Noam Camus
2015-08-17 17:36 ` [v1 0/6] *** nps_enet fixups *** David Miller
2015-08-18 5:04 ` Noam Camus
2015-08-18 5:26 ` David Miller [this message]
2015-08-20 5:00 ` [v2 0/5] " Noam Camus
2015-08-20 5:00 ` [v2 1/5] NET: nps_enet: replace use of cause register Noam Camus
2015-08-20 5:00 ` [v2 2/5] NET: nps_enet: TX done race condition Noam Camus
2015-08-20 5:00 ` [v2 3/5] NET: nps_enet: drop control frames Noam Camus
2015-08-20 5:00 ` [v2 4/5] NET: nps_enet: TX done acknowledge Noam Camus
2015-08-20 5:00 ` [v2 5/5] NET: nps_enet: minor namespace cleanup Noam Camus
2015-08-23 23:09 ` [v2 0/5] *** nps_enet fixups *** David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150817.222620.475853456939322841.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Alexey.Brodkin@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noamc@ezchip.com \
--cc=talz@ezchip.com \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®