From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Mark Brown <broonie@kernel.org>,
Andy Gross <agross@codeaurora.org>,
"Bird, Tim" <Tim.Bird@sonymobile.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: qcom_smd: Set n_voltages for pm8941_lnldo
Date: Wed, 19 Aug 2015 09:04:33 -0700 [thread overview]
Message-ID: <20150819160433.GW13472@usrtlx11787.corpusers.net> (raw)
In-Reply-To: <1439954273.19082.2.camel@ingics.com>
On Tue 18 Aug 20:17 PDT 2015, Axel Lin wrote:
> Just setting fixed_uV is not enough, the regulator core will also check
> n_voltages setting. The fixed_uV only works when n_voltages is 1.
>
Thanks, I missed that.
Reviewed-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/qcom_smd-regulator.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
> index 9d093ae..9c6167d 100644
> --- a/drivers/regulator/qcom_smd-regulator.c
> +++ b/drivers/regulator/qcom_smd-regulator.c
> @@ -203,6 +203,7 @@ static const struct regulator_desc pm8941_nldo = {
>
> static const struct regulator_desc pm8941_lnldo = {
> .fixed_uV = 1740000,
> + .n_voltages = 1,
> .ops = &rpm_smps_ldo_ops,
> };
>
> --
> 2.1.0
>
>
>
prev parent reply other threads:[~2015-08-19 16:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 3:17 Axel Lin
2015-08-19 16:04 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819160433.GW13472@usrtlx11787.corpusers.net \
--to=bjorn.andersson@sonymobile.com \
--cc=Tim.Bird@sonymobile.com \
--cc=agross@codeaurora.org \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®