From: Jiri Olsa <jolsa@redhat.com>
To: Kan Liang <kan.liang@intel.com>
Cc: acme@kernel.org, a.p.zijlstra@chello.nl, luto@kernel.org,
mingo@redhat.com, eranian@google.com, ak@linux.intel.com,
mark.rutland@arm.com, adrian.hunter@intel.com, jolsa@kernel.org,
namhyung@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 1/7] perf,tools: introduce generic FEAT for CPU attributes
Date: Fri, 21 Aug 2015 10:55:00 +0200 [thread overview]
Message-ID: <20150821085500.GA23142@krava.brq.redhat.com> (raw)
In-Reply-To: <1439907401-37226-2-git-send-email-kan.liang@intel.com>
On Tue, Aug 18, 2015 at 10:16:35AM -0400, Kan Liang wrote:
SNIP
> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> index 179b2bd..0a06fb8 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
> @@ -862,6 +862,23 @@ write_it:
> return do_write_string(fd, buffer);
> }
>
> +#define MAX_FREQ_TAG_STR "max_freq"
> +
> +static int write_cpu_attributes(int fd, struct perf_header *h __maybe_unused,
> + struct perf_evlist *evlist __maybe_unused)
> +{
> + u64 freq;
> + int ret;
> +
> + freq = get_cpu_max_freq();
> +
> + ret = do_write_string(fd, MAX_FREQ_TAG_STR);
> + if (ret)
> + return ret;
why not store just the tag number? PERF_HEADER_CPU_MAX_FREQ
jirka
next prev parent reply other threads:[~2015-08-21 8:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 14:16 [PATCH V4 0/7] Freq/CPU%/CORE_BUSY% support Kan Liang
2015-08-18 14:16 ` [PATCH V4 1/7] perf,tools: introduce generic FEAT for CPU attributes Kan Liang
2015-08-21 8:55 ` Jiri Olsa [this message]
2015-08-21 8:57 ` Jiri Olsa
2015-08-21 14:22 ` Liang, Kan
2015-08-18 14:16 ` [PATCH V4 2/7] perf,tools: read msr pmu type from header Kan Liang
2015-08-18 14:16 ` [PATCH V4 3/7] perf,tools: rename perf_session_env and add backpointer to evlist Kan Liang
2015-08-18 14:16 ` [PATCH V4 4/7] perf evsel: Add a backpointer to the evlist a evsel is in Kan Liang
2015-08-18 14:16 ` [PATCH V4 5/7] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY% in report -D Kan Liang
2015-08-18 14:16 ` [PATCH V4 6/7] perf,tools: caculate and save freq/CPU%/CORE_BUSY% in he_stat Kan Liang
2015-08-18 14:16 ` [PATCH V4 7/7] perf,tools: Show freq/CPU%/CORE_BUSY% in perf report --stdio Kan Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150821085500.GA23142@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®