Re: [PATCH V4 1/7] perf,tools: introduce generic FEAT for CPU attributes

[Jiri Olsa <jolsa@redhat.com>]

On Tue, Aug 18, 2015 at 10:16:35AM -0400, Kan Liang wrote:

SNIP

> diff --git a/tools/perf/util/header.h b/tools/perf/util/header.h
> index 9b53b65..233c24d 100644
> --- a/tools/perf/util/header.h
> +++ b/tools/perf/util/header.h
> @@ -31,6 +31,7 @@ enum {
>  	HEADER_PMU_MAPPINGS,
>  	HEADER_GROUP_DESC,
>  	HEADER_AUXTRACE,
> +	HEADER_CPU_ATTR,
>  	HEADER_LAST_FEATURE,
>  	HEADER_FEAT_BITS	= 256,
>  };
> @@ -66,6 +67,11 @@ struct perf_header;
>  int perf_file_header__read(struct perf_file_header *header,
>  			   struct perf_header *ph, int fd);
>  
> +enum perf_header_cpu_attr {
> +	PERF_HEADER_CPU_MAX_FREQ	= 0,
> +	PERF_HEADER_CPU_ATTR_MAX,
> +};
> +
>  struct perf_session_env {
>  	char			*hostname;
>  	char			*os_release;
> @@ -75,6 +81,7 @@ struct perf_session_env {
>  	int			nr_cpus_avail;
>  	char			*cpu_desc;
>  	char			*cpuid;
> +	u64			cpu_attr[PERF_HEADER_CPU_ATTR_MAX];

it'd more readable having struct with all fields
instead of the tag accesible array

jirka