* [RESEND PATCH v1 0/1] A misjudgement should be fixed
@ 2015-08-25 7:52 Xing Zheng
2015-08-25 7:52 ` [RESEND PATCH v1] ASoC: rockchip: fix a misjudgement by return Xing Zheng
2015-08-25 16:33 ` [RESEND PATCH v1 0/1] A misjudgement should be fixed Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Xing Zheng @ 2015-08-25 7:52 UTC (permalink / raw)
To: dgreid, dianders, heiko, sonnyrao
Cc: linux-rockchip, Xing Zheng, Jaroslav Kysela, alsa-devel,
Mark Brown, linux-kernel, Takashi Iwai, Liam Girdwood,
linux-arm-kernel
Hi,
Being careless, judge the return value of snd_soc_card_jack_new
is opposite, so it should be fixed.
Thanks.
Changes in v1:
Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Xing Zheng (1):
ASoC: rockchip: fix a misjudgement by return
sound/soc/rockchip/rockchip_rt5645.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RESEND PATCH v1] ASoC: rockchip: fix a misjudgement by return
2015-08-25 7:52 [RESEND PATCH v1 0/1] A misjudgement should be fixed Xing Zheng
@ 2015-08-25 7:52 ` Xing Zheng
2015-08-25 16:33 ` [RESEND PATCH v1 0/1] A misjudgement should be fixed Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Xing Zheng @ 2015-08-25 7:52 UTC (permalink / raw)
To: dgreid, dianders, heiko, sonnyrao
Cc: linux-rockchip, Xing Zheng, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-arm-kernel,
linux-kernel
Being careless, judge the return value of snd_soc_card_jack_new
is opposite, so it should be fixed.
---
Changes in v1:
Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
Reviewed-by: Dylan Reid <dgreid@chromium.org>
sound/soc/rockchip/rockchip_rt5645.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/rockchip/rockchip_rt5645.c b/sound/soc/rockchip/rockchip_rt5645.c
index 3c6bb1e..adfe98c 100644
--- a/sound/soc/rockchip/rockchip_rt5645.c
+++ b/sound/soc/rockchip/rockchip_rt5645.c
@@ -118,7 +118,7 @@ static int rk_init(struct snd_soc_pcm_runtime *runtime)
SND_JACK_BTN_0 | SND_JACK_BTN_1 |
SND_JACK_BTN_2 | SND_JACK_BTN_3,
&headset_jack, NULL, 0);
- if (!ret) {
+ if (ret) {
dev_err(card->dev, "New Headset Jack failed! (%d)\n", ret);
return ret;
}
--
1.7.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RESEND PATCH v1 0/1] A misjudgement should be fixed
2015-08-25 7:52 [RESEND PATCH v1 0/1] A misjudgement should be fixed Xing Zheng
2015-08-25 7:52 ` [RESEND PATCH v1] ASoC: rockchip: fix a misjudgement by return Xing Zheng
@ 2015-08-25 16:33 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2015-08-25 16:33 UTC (permalink / raw)
To: Xing Zheng
Cc: dgreid, dianders, heiko, sonnyrao, linux-rockchip,
Jaroslav Kysela, alsa-devel, linux-kernel, Takashi Iwai,
Liam Girdwood, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 331 bytes --]
On Tue, Aug 25, 2015 at 03:52:41PM +0800, Xing Zheng wrote:
>
> Hi,
> Being careless, judge the return value of snd_soc_card_jack_new
> is opposite, so it should be fixed.
Please don't send cover letters for single patches, if there is anything
useful it should either be in the changelog or after the --- in the
patch.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-25 16:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-25 7:52 [RESEND PATCH v1 0/1] A misjudgement should be fixed Xing Zheng
2015-08-25 7:52 ` [RESEND PATCH v1] ASoC: rockchip: fix a misjudgement by return Xing Zheng
2015-08-25 16:33 ` [RESEND PATCH v1 0/1] A misjudgement should be fixed Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®