* [PATCH 2/6] input: pwm-beeper: Fix module autoload for OF platform driver
@ 2015-08-27 16:59 Luis de Bethencourt
2015-08-29 0:00 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Luis de Bethencourt @ 2015-08-27 16:59 UTC (permalink / raw)
To: linux-kernel
Cc: Dmitry Torokhov, Jingoo Han, Wolfram Sang, Olivier Sobrie,
linux-input, Javier Martinez Canillas
This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.
Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
---
drivers/input/misc/pwm-beeper.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
index e82edf8..a02b9a4 100644
--- a/drivers/input/misc/pwm-beeper.c
+++ b/drivers/input/misc/pwm-beeper.c
@@ -175,6 +175,8 @@ static const struct of_device_id pwm_beeper_match[] = {
};
#endif
+MODULE_DEVICE_TABLE(of, pwm_beeper_match);
+
static struct platform_driver pwm_beeper_driver = {
.probe = pwm_beeper_probe,
.remove = pwm_beeper_remove,
--
2.4.6
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 2/6] input: pwm-beeper: Fix module autoload for OF platform driver
2015-08-27 16:59 [PATCH 2/6] input: pwm-beeper: Fix module autoload for OF platform driver Luis de Bethencourt
@ 2015-08-29 0:00 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2015-08-29 0:00 UTC (permalink / raw)
To: Luis de Bethencourt
Cc: lkml, Jingoo Han, Wolfram Sang, Olivier Sobrie, linux-input,
Javier Martinez Canillas
Hi Luis,
On Thu, Aug 27, 2015 at 9:59 AM, Luis de Bethencourt
<luis@debethencourt.com> wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> ---
> drivers/input/misc/pwm-beeper.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
> index e82edf8..a02b9a4 100644
> --- a/drivers/input/misc/pwm-beeper.c
> +++ b/drivers/input/misc/pwm-beeper.c
> @@ -175,6 +175,8 @@ static const struct of_device_id pwm_beeper_match[] = {
> };
> #endif
>
> +MODULE_DEVICE_TABLE(of, pwm_beeper_match);
> +
I'm fairly certain this (ano others) blow up in case of !CONFIG_OF.
Please bring MODULE_DEVICE_TABLE into #ifdef block above.
> static struct platform_driver pwm_beeper_driver = {
> .probe = pwm_beeper_probe,
> .remove = pwm_beeper_remove,
> --
> 2.4.6
>
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-29 0:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-27 16:59 [PATCH 2/6] input: pwm-beeper: Fix module autoload for OF platform driver Luis de Bethencourt
2015-08-29 0:00 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®