mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Kan Liang <kan.liang@intel.com>
Cc: jolsa@kernel.org, a.p.zijlstra@chello.nl, luto@kernel.org,
	mingo@redhat.com, eranian@google.com, ak@linux.intel.com,
	mark.rutland@arm.com, adrian.hunter@intel.com,
	namhyung@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V7 4/8] perf,tools: add backpointer for perf_env to evlist
Date: Fri, 28 Aug 2015 14:45:46 -0300	[thread overview]
Message-ID: <20150828174546.GI11407@kernel.org> (raw)
In-Reply-To: <1440755289-30939-5-git-send-email-kan.liang@intel.com>

Em Fri, Aug 28, 2015 at 05:48:05AM -0400, Kan Liang escreveu:
> From: Kan Liang <kan.liang@intel.com>
> 
> Add backpointer to evlist, so we can easily access env when processing
> something where we have a evsel or evlist.

This is already in my perf/core branch.
 
> Suggested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> Signed-off-by: Kan Liang <kan.liang@intel.com>
> ---
>  tools/perf/util/evlist.h | 1 +
>  tools/perf/util/header.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h
> index 436e358..b39a619 100644
> --- a/tools/perf/util/evlist.h
> +++ b/tools/perf/util/evlist.h
> @@ -56,6 +56,7 @@ struct perf_evlist {
>  	struct cpu_map	  *cpus;
>  	struct perf_evsel *selected;
>  	struct events_stats stats;
> +	struct perf_env	*env;
>  };
>  
>  struct perf_evsel_str_handler {
> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> index 8df0582..c3c79cb 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
> @@ -2576,6 +2576,7 @@ int perf_session__read_header(struct perf_session *session)
>  	if (session->evlist == NULL)
>  		return -ENOMEM;
>  
> +	session->evlist->env = &header->env;
>  	if (perf_data_file__is_pipe(file))
>  		return perf_header__read_pipe(session);
>  
> -- 
> 1.8.3.1

  reply	other threads:[~2015-08-28 17:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-28  9:48 [PATCH V7 0/8] Freq/CPU%/CORE_BUSY% support Kan Liang
2015-08-28  9:48 ` [PATCH V7 1/8] perf,tools: introduce generic FEAT for CPU attributes Kan Liang
2015-08-31  9:46   ` Jiri Olsa
2015-08-28  9:48 ` [PATCH V7 2/8] perf,tools: read msr pmu type from header Kan Liang
2015-08-31  9:49   ` Jiri Olsa
2015-08-28  9:48 ` [PATCH V7 3/8] perf,tools: rename perf_session_env to perf_env Kan Liang
2015-08-28 17:45   ` Arnaldo Carvalho de Melo
2015-08-31  8:33   ` [tip:perf/core] perf tools: Rename " tip-bot for Kan Liang
2015-08-28  9:48 ` [PATCH V7 4/8] perf,tools: add backpointer for perf_env to evlist Kan Liang
2015-08-28 17:45   ` Arnaldo Carvalho de Melo [this message]
2015-08-31  8:33   ` [tip:perf/core] perf evlist: Add " tip-bot for Kan Liang
2015-08-28  9:48 ` [PATCH V7 5/8] perf evsel: Add a backpointer to the evlist a evsel is in Kan Liang
2015-08-28 17:47   ` Arnaldo Carvalho de Melo
2015-08-28  9:48 ` [PATCH V7 6/8] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY% in report -D Kan Liang
2015-08-31 11:19   ` Jiri Olsa
2015-08-31 19:10     ` Liang, Kan
2015-08-31 11:19   ` Jiri Olsa
2015-08-31 20:33     ` Arnaldo Carvalho de Melo
2015-08-28  9:48 ` [PATCH V7 7/8] perf,tools: caculate and save freq/CPU%/CORE_BUSY% in he_stat Kan Liang
2015-08-28  9:48 ` [PATCH V7 8/8] perf,tools: Show freq/CPU%/CORE_BUSY% in perf report --stdio Kan Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150828174546.GI11407@kernel.org \
    --to=acme@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=eranian@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome