From: Jiri Olsa <jolsa@redhat.com>
To: Kan Liang <kan.liang@intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, a.p.zijlstra@chello.nl,
luto@kernel.org, mingo@redhat.com, eranian@google.com,
ak@linux.intel.com, mark.rutland@arm.com,
adrian.hunter@intel.com, namhyung@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V7 6/8] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY% in report -D
Date: Mon, 31 Aug 2015 13:19:40 +0200 [thread overview]
Message-ID: <20150831111940.GI22039@krava.brq.redhat.com> (raw)
In-Reply-To: <1440755289-30939-7-git-send-email-kan.liang@intel.com>
On Fri, Aug 28, 2015 at 05:48:07AM -0400, Kan Liang wrote:
SNIP
>
> static struct machine *machines__find_for_cpumode(struct machines *machines,
> @@ -1079,11 +1101,12 @@ static int machines__deliver_event(struct machines *machines,
>
> switch (event->header.type) {
> case PERF_RECORD_SAMPLE:
> - dump_sample(evsel, event, sample);
> if (evsel == NULL) {
> ++evlist->stats.nr_unknown_id;
> return 0;
> }
> + dump_sample(evsel, event, sample);
> +
could you submit this hunk separately.. seems like we could
segfault in dump_sample if there's evsel == NULL, right?
jirka
next prev parent reply other threads:[~2015-08-31 11:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 9:48 [PATCH V7 0/8] Freq/CPU%/CORE_BUSY% support Kan Liang
2015-08-28 9:48 ` [PATCH V7 1/8] perf,tools: introduce generic FEAT for CPU attributes Kan Liang
2015-08-31 9:46 ` Jiri Olsa
2015-08-28 9:48 ` [PATCH V7 2/8] perf,tools: read msr pmu type from header Kan Liang
2015-08-31 9:49 ` Jiri Olsa
2015-08-28 9:48 ` [PATCH V7 3/8] perf,tools: rename perf_session_env to perf_env Kan Liang
2015-08-28 17:45 ` Arnaldo Carvalho de Melo
2015-08-31 8:33 ` [tip:perf/core] perf tools: Rename " tip-bot for Kan Liang
2015-08-28 9:48 ` [PATCH V7 4/8] perf,tools: add backpointer for perf_env to evlist Kan Liang
2015-08-28 17:45 ` Arnaldo Carvalho de Melo
2015-08-31 8:33 ` [tip:perf/core] perf evlist: Add " tip-bot for Kan Liang
2015-08-28 9:48 ` [PATCH V7 5/8] perf evsel: Add a backpointer to the evlist a evsel is in Kan Liang
2015-08-28 17:47 ` Arnaldo Carvalho de Melo
2015-08-28 9:48 ` [PATCH V7 6/8] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY% in report -D Kan Liang
2015-08-31 11:19 ` Jiri Olsa
2015-08-31 19:10 ` Liang, Kan
2015-08-31 11:19 ` Jiri Olsa [this message]
2015-08-31 20:33 ` Arnaldo Carvalho de Melo
2015-08-28 9:48 ` [PATCH V7 7/8] perf,tools: caculate and save freq/CPU%/CORE_BUSY% in he_stat Kan Liang
2015-08-28 9:48 ` [PATCH V7 8/8] perf,tools: Show freq/CPU%/CORE_BUSY% in perf report --stdio Kan Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150831111940.GI22039@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome