From: Jiri Olsa <jolsa@redhat.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
kan.liang@intel.com, mingo@kernel.org, jolsa@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [tip:perf/urgent] perf evlist: Open event on evsel cpus and threads
Date: Thu, 3 Sep 2015 21:04:11 +0200 [thread overview]
Message-ID: <20150903190411.GA24774@krava.redhat.com> (raw)
In-Reply-To: <55E89398.7040802@intel.com>
On Thu, Sep 03, 2015 at 09:38:16PM +0300, Adrian Hunter wrote:
SNIP
> >
> >perf_evlist__propagate_maps is called from perf_evlist__create_maps,
> >so if evsel is added later it will not be affected, perhaps we need
> >something like below
>
> Yes but it would be nice to have a single function to do it that knows
> the rules for when the evsel->cpus should be retained. Say:
> int __perf_evlist__propagate_maps(struct perf_evlist *evlist, struct perf_evsel *evsel)
> then call it from perf_evlist__propagate_maps(), perf_evlist__add() and
> perf_evlist__splice_list_tail(). Probably need to add a member to perf_evlist
> to know when the evlist->cpus should replace the evsel->cpus
ook,
jirka
next prev parent reply other threads:[~2015-09-03 19:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 6:23 [PATCH 1/1] perf,tools: open " kan.liang
2015-08-21 13:54 ` Jiri Olsa
2015-08-31 20:31 ` Arnaldo Carvalho de Melo
2015-08-31 21:06 ` Liang, Kan
2015-08-31 21:14 ` Arnaldo Carvalho de Melo
2015-08-31 21:28 ` Liang, Kan
2015-08-31 21:34 ` Arnaldo Carvalho de Melo
2015-09-01 8:31 ` [tip:perf/urgent] perf evlist: Open " tip-bot for Kan Liang
2015-09-03 13:34 ` Adrian Hunter
2015-09-03 15:27 ` Arnaldo Carvalho de Melo
2015-09-03 16:23 ` Adrian Hunter
2015-09-03 16:41 ` Arnaldo Carvalho de Melo
2015-09-03 18:19 ` Jiri Olsa
2015-09-03 18:38 ` Adrian Hunter
2015-09-03 19:04 ` Jiri Olsa [this message]
2015-09-03 20:41 ` Arnaldo Carvalho de Melo
2015-09-04 7:05 ` Jiri Olsa
2015-09-04 7:09 ` Adrian Hunter
2015-09-04 12:15 ` [PATCH] perf tools: Fix gaps propagating maps Adrian Hunter
2015-09-04 13:28 ` Arnaldo Carvalho de Melo
2015-09-04 13:42 ` Adrian Hunter
2015-09-04 14:48 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150903190411.GA24774@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome