From: Namhyung Kim <namhyung@kernel.org>
To: "平松雅巳 / HIRAMATU，MASAMI" <masami.hiramatsu.pt@hitachi.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
Wang Nan <wangnan0@huawei.com>,
"pi3orama@163.com" <pi3orama@163.com>,
sysp-manager <cti.systems-productivity-manager.ts@hitachi.com>
Subject: Re: [PATCH 2/5] perf probe: Attach trace_probe_event with perf_probe_event
Date: Fri, 4 Sep 2015 20:52:36 +0900 [thread overview]
Message-ID: <20150904115236.GA11132@danjae.kornet> (raw)
In-Reply-To: <50399556C9727B4D88A595C8584AAB375250D1DC@GSjpTKYDCembx32.service.hitachi.net>
On Fri, Sep 04, 2015 at 11:36:56AM +0000, 平松雅巳 / HIRAMATU，MASAMI wrote:
> > From: Namhyung Kim [mailto:namhyung@kernel.org]
Oh, this patch is came from Wang Nan. I missed to update the author,
will change in v2.
> >
> > This patch drops struct __event_package structure. Instead, it adds
> > trace_probe_event into 'struct perf_probe_event'.
> >
> > trace_probe_event information gives further patches a chance to access
> > actual probe points and actual arguments. Using them, perf probe can
> > get whole list of added probes and print them at once.
> >
> > Other users like upcoming bpf_loader will be able to attach one bpf
> > program to different probing points of an inline functions (which has
> > multiple probing points) and glob functions. Moreover, by reading
> > arguments information, bpf code for reading those arguments can be
> > generated.
>
> Looks good to me.
>
> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Thanks
Namhyung
next prev parent reply other threads:[~2015-09-04 11:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 7:39 [PATCH 1/5] perf probe: Split add_perf_probe_events() Namhyung Kim
2015-09-04 7:39 ` [PATCH 2/5] perf probe: Attach trace_probe_event with perf_probe_event Namhyung Kim
2015-09-04 11:36 ` 平松雅巳 / HIRAMATU，MASAMI
2015-09-04 11:52 ` Namhyung Kim [this message]
2015-09-04 7:39 ` [PATCH 3/5] perf probe: Move print logic into cmd_probe() Namhyung Kim
2015-09-04 11:48 ` 平松雅巳 / HIRAMATU，MASAMI
2015-09-04 7:39 ` [PATCH 4/5] perf probe: Split del_perf_probe_events() Namhyung Kim
2015-09-04 11:52 ` 平松雅巳 / HIRAMATU，MASAMI
2015-09-04 12:14 ` Namhyung Kim
2015-09-04 7:39 ` [PATCH 5/5] perf probe: Print deleted events in cmd_probe() Namhyung Kim
2015-09-04 11:46 ` 平松雅巳 / HIRAMATU，MASAMI
2015-09-04 11:53 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150904115236.GA11132@danjae.kornet \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=cti.systems-productivity-manager.ts@hitachi.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®