From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing
Date: Tue, 8 Sep 2015 18:20:47 +0200 [thread overview]
Message-ID: <20150908162047.GK2038@krava.brq.redhat.com> (raw)
In-Reply-To: <20150908160317.GF4524@tassilo.jf.intel.com>
On Tue, Sep 08, 2015 at 09:03:17AM -0700, Andi Kleen wrote:
> > - introduce the print_metrics interface for perf_stat__print_shadow_stats
> > - introduce printout function
> > - introduce support for printing metrics in csv in interval mode
>
> That's already a separate patch.
>
> > - and enable i
> >
> >
> > or any other way you find feasible *easy to review*.. I cannot ack it at this state
>
> Well it's just printing out values. It's really not rocket science. Nobody
> is asking you to review a new VM subsystems or something like that.
right, it's easy.. and it should be done in 'easy to review' way
>
> I expect each more "refactoring" to add more problems. It's just really hard to to do,
> and usually adds more problems.
yep, that's why we test things
>
> I can try one more time, but if it doesn't work out we'll have to give up on this.
ok
jirka
next prev parent reply other threads:[~2015-09-08 16:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 22:45 perf, tools: Refactor and support interval and CSV metrics v4 Andi Kleen
2015-09-04 22:45 ` [PATCH 1/6] perf, tools, stat: Move sw clock metrics printout to stat-shadow Andi Kleen
2015-09-04 22:50 ` Arnaldo Carvalho de Melo
2015-09-04 22:45 ` [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing Andi Kleen
2015-09-07 11:43 ` Jiri Olsa
2015-09-07 12:14 ` Jiri Olsa
2015-09-08 16:03 ` Andi Kleen
2015-09-08 16:20 ` Jiri Olsa [this message]
2015-09-04 22:45 ` [PATCH 3/6] perf, tools, stat: Add support for metrics in interval mode Andi Kleen
2015-09-04 22:45 ` [PATCH 4/6] perf, tools, stat: Move noise/running printing into printout Andi Kleen
2015-09-04 22:45 ` [PATCH 5/6] perf, tools, stat: Implement CSV metrics output Andi Kleen
2015-09-04 22:45 ` [PATCH 6/6] perf, tools, stat: Move non counting counter printing to printout Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150908162047.GK2038@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®