From: Mikko Rapeli <mikko.rapeli@iki.fi>
To: tglx@linutronix.de, peterz@infradead.org, mingo@kernel.org,
bp@alien8.de, dvlasenk@redhat.com, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org, brgerst@gmail.com, oleg@redhat.com,
hpa@zytor.com, luto@amacapital.net
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/headers] x86/headers: Remove <asm/sigcontext.h> references on the kernel side
Date: Tue, 8 Sep 2015 23:17:25 +0300 [thread overview]
Message-ID: <20150908201725.GH9187@lakka.kapsi.fi> (raw)
In-Reply-To: <tip-decb4c41159e1511197f2964da758fa7f2eeb741@git.kernel.org>
Hi,
Tested these changes on top of my uapi headers fix branch and
they compile without problems in userspace and thus fix the original issue.
Also abi-compliance-checker reports that these changes don't break anything
in i386 ABI (details at [2]):
"Test Info
Library Name kernel
Version #1 headers_test_v04
Version #2 headers_test_v04+test_ingo_x86_cleanup
CPU Type x86
GCC Version 5.2.1
Subject Binary Compatibility
Test Results
Total Header Files 767
Total Shared Libraries 0 (not analyzed)
Total Symbols / Types 62 / 67
Verdict Compatible"
or API:
"Test Info
Library Name kernel
Version #1 headers_test_v04
Version #2 headers_test_v04+test_ingo_x86_cleanup
CPU Type x86
GCC Version 5.2.1
Subject Source Compatibility
Test Results
Total Header Files 767
Total Shared Libraries 0 (not analyzed)
Total Symbols / Types 96 / 101
Verdict Compatible"
While abi-compliance-checker is still quite broken with kernel header files[3]
addition of new constants was correctly detected:
"Other Changes in Constants (3)
sigcontext.h
[−] _fpstate
Change Effect
1 The constant _fpstate with value _fpstate_32 has been added. No effect.
[−] _fpstate_ia32
Change Effect
1 The constant _fpstate_ia32 with value _fpstate_32 has been added. No effect.
[−] sigcontext_ia32
Change Effect
1 The constant sigcontext_ia32 with value sigcontext_32 has been added. No effect."
So for 32 bit userspace side
Tested-by: Mikko Rapeli <mikko.rapeli@iki.fi>
-Mikko
[1] http://lvc.github.io/abi-compliance-checker/
[2] API/ABI check results
https://mcfrisk.kapsi.fi/temp/headers_test_v04_to_headers_test_v04+test_ingo_x86_cleanup/
[3] abi checker still has some issues with kernel headers:
https://mcfrisk.kapsi.fi/temp/headers_test_v04+test_ingo_x86_cleanup/log.txt
prev parent reply other threads:[~2015-09-08 20:18 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-05 7:32 [PATCH 00/15] x86/headers: Clean up sigcontext types and headers Ingo Molnar
2015-09-05 7:32 ` [PATCH 01/15] x86/headers: Fix (old) header file dependency bug in uapi/asm/sigcontext32.h Ingo Molnar
2015-09-08 14:24 ` [tip:x86/headers] " tip-bot for Ingo Molnar
2015-09-05 7:32 ` [PATCH 02/15] x86/headers: Clean up uapi/asm/sigcontext32.h Ingo Molnar
2015-09-08 14:25 ` [tip:x86/headers] " tip-bot for Ingo Molnar
2015-09-05 7:32 ` [PATCH 03/15] x86/headers: Clean up and better document uapi/asm/sigcontext.h Ingo Molnar
2015-09-08 14:25 ` [tip:x86/headers] x86/headers: Clean up and better document uapi/ asm/sigcontext.h tip-bot for Ingo Molnar
2015-09-09 7:12 ` Peter Zijlstra
2015-09-14 9:12 ` [tip:x86/headers] x86/headers: Clean up too long lines tip-bot for Peter Zijlstra
2015-09-05 7:32 ` [PATCH 04/15] x86/headers: Separate out legacy user-space structure definitions Ingo Molnar
2015-09-08 14:25 ` [tip:x86/headers] " tip-bot for Ingo Molnar
2015-09-05 7:32 ` [PATCH 05/15] x86/headers: Use ABI types consistently in sigcontext*.h Ingo Molnar
2015-09-08 14:26 ` [tip:x86/headers] " tip-bot for Ingo Molnar
2015-09-05 7:32 ` [PATCH 06/15] x86/headers: Unify register type definitions between 32-bit compat and i386 Ingo Molnar
2015-09-08 14:26 ` [tip:x86/headers] " tip-bot for Ingo Molnar
2015-09-05 7:32 ` [PATCH 07/15] x86/headers: Unify 'struct _fpstate_ia32' and i386 struct _fpstate Ingo Molnar
2015-09-08 14:26 ` [tip:x86/headers] " tip-bot for Ingo Molnar
2015-09-05 7:32 ` [PATCH 08/15] x86/headers: Convert uses of _fpstate_ia32 to _fpstate_32 Ingo Molnar
2015-09-08 14:27 ` [tip:x86/headers] " tip-bot for Ingo Molnar
2015-09-05 7:32 ` [PATCH 09/15] x86/headers: Clean up the kernel's struct sigcontext types to be ABI-clean Ingo Molnar
2015-09-08 14:27 ` [tip:x86/headers] x86/headers: Clean up the kernel' s " tip-bot for Ingo Molnar
2015-09-05 7:32 ` [PATCH 10/15] x86/headers: Move the 'struct sigcontext' definitions into the UAPI header Ingo Molnar
2015-09-08 14:27 ` [tip:x86/headers] " tip-bot for Ingo Molnar
2015-09-05 7:32 ` [PATCH 11/15] x86/headers: Make sigcontext pointers bit independent Ingo Molnar
2015-09-08 14:28 ` [tip:x86/headers] " tip-bot for Ingo Molnar
2015-09-05 7:32 ` [PATCH 12/15] x86/headers: Unify 'struct sigcontext_ia32' and 'struct sigcontext_32' Ingo Molnar
2015-09-08 14:28 ` [tip:x86/headers] " tip-bot for Ingo Molnar
2015-09-05 7:32 ` [PATCH 13/15] x86/headers: Convert sigcontext_ia32 uses to sigcontext_32 Ingo Molnar
2015-09-08 14:28 ` [tip:x86/headers] " tip-bot for Ingo Molnar
2015-09-05 7:32 ` [PATCH 14/15] x86/headers: Remove direct sigcontext32.h uses Ingo Molnar
2015-09-08 14:29 ` [tip:x86/headers] " tip-bot for Ingo Molnar
2015-09-05 7:32 ` [PATCH 15/15] x86/headers: Remove <asm/sigcontext.h> Ingo Molnar
2015-09-05 10:57 ` Mikko Rapeli
2015-09-05 11:59 ` Ingo Molnar
2015-09-05 12:11 ` Mikko Rapeli
2015-09-06 6:41 ` Ingo Molnar
2015-09-06 20:28 ` Mikko Rapeli
2015-09-07 7:37 ` Ingo Molnar
2015-09-07 8:14 ` Mikko Rapeli
2015-09-08 14:29 ` [tip:x86/headers] x86/headers: Remove <asm/sigcontext.h> references on the kernel side tip-bot for Ingo Molnar
2015-09-08 20:17 ` Mikko Rapeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150908201725.GH9187@lakka.kapsi.fi \
--to=mikko.rapeli@iki.fi \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®