From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
olof@lixom.net, khilman@kernel.org, afaerber@suse.de,
u.kleine-koenig@pengutronix.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] ARM: Make FORCE_MAX_ZONEORDER configurable if ARM_SINGLE_ARMV7M
Date: Tue, 8 Sep 2015 23:19:13 +0100 [thread overview]
Message-ID: <20150908221912.GE21084@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1441744686-20521-2-git-send-email-mcoquelin.stm32@gmail.com>
On Tue, Sep 08, 2015 at 10:38:04PM +0200, Maxime Coquelin wrote:
> This patch makes FORCE_MAX_ZONEORDER configurable in defconfig for ARMV7-M
> when built for a single platform.
I'd prefer if we didn't do this, because this isn't supposed to be a user
visible "option". It's an option that was introduced to avoid having to
throw masses of #ifdefs into the definition of MAX_ZONEORDER.
The problem with it is that it's a "well, what do I set this to?" option
and that leads to "oh, I'll just choose the default because I don't know
any better".
Do we know why EFM32 needs a value of 9 here? It's not documented in
the original commit, and it really _should_ have been.
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-09-08 22:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 20:38 [PATCH v2 0/3] ARMv7-M: Make FORCE_MAX_ZONE_ORDER configurable from defconfig Maxime Coquelin
2015-09-08 20:38 ` [PATCH v2 1/3] ARM: Make FORCE_MAX_ZONEORDER configurable if ARM_SINGLE_ARMV7M Maxime Coquelin
2015-09-08 22:19 ` Russell King - ARM Linux [this message]
2015-09-09 5:41 ` Uwe Kleine-König
2015-09-10 7:53 ` Uwe Kleine-König
2015-09-09 6:48 ` Maxime Coquelin
2015-09-08 20:38 ` [PATCH v2 2/3] ARM: configs: Set FORCE_MAX_ZONE_ORDER to 9 in stm32_defconfig Maxime Coquelin
2015-09-08 20:38 ` [PATCH v2 3/3] ARM: configs: Set FORCE_MAX_ZONEORDER to 9 in efm32_defconfig Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150908221912.GE21084@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=afaerber@suse.de \
--cc=arnd@arndb.de \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=olof@lixom.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®