mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	acme@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf, tools, pmu-events: Fix fixed counters on Intel
Date: Wed, 9 Sep 2015 14:24:29 -0700	[thread overview]
Message-ID: <20150909212429.GI4524@tassilo.jf.intel.com> (raw)
In-Reply-To: <20150909205858.GA30739@us.ibm.com>

> 
> pmu-events/jevents.c:247:2: error: missing initializer for field ‘name’ of ‘struct fixed’ [-Werror=missing-field-initializers]

Thanks.

Somehow a WERROR=0 must have slipped into the build script again.


> After this I was able to get non-zero counts for the 'inst_retired.any'
> event on my system. Without the patch, I get 0 count for the event.
> 
> I pushed this commit to the 'json-v16' branch.
> 
> I also noticed an "Unknown MSR" message when building 'jevents':
> 
>   CC       /root/suka/linux-acme.git/tools/perf/perf-obj/pmu-events/jevents.o
>   LD       /root/suka/linux-acme.git/tools/perf/perf-obj/pmu-events/jevents-in.o
>   LINK     /root/suka/linux-acme.git/tools/perf/perf-obj/pmu-events/jevents
>   GEN      /root/suka/linux-acme.git/tools/perf/perf-obj/pmu-events/pmu-events.c
> jevents: Unknown MSR in event file 0x3F7

I'll take a look and send a patch for that.

-Andi

      reply	other threads:[~2015-09-09 21:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-04 18:33 Andi Kleen
2015-09-09 20:58 ` Sukadev Bhattiprolu
2015-09-09 21:24   ` Andi Kleen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150909212429.GI4524@tassilo.jf.intel.com \
    --to=ak@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sukadev@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome