From: Mark Brown <broonie@kernel.org>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
Heiko Stuebner <heiko@sntech.de>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Doug Anderson <dianders@chromium.org>,
Olof Johansson <olofj@google.com>,
Sonny Rao <sonnyrao@chromium.org>,
Addy Ke <addy.ke@rock-chips.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org,
linux-spi@vger.kernel.org, Yiwei Cai <cain.cai@rock-chips.com>,
Jianqun Xu <xjq@rock-chips.com>, Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH v4 10/10] ASoC: rockchip_i2s: modify DMA max burst to 1
Date: Fri, 11 Sep 2015 12:53:31 +0100 [thread overview]
Message-ID: <20150911115331.GM12027@sirena.org.uk> (raw)
In-Reply-To: <1441502008-14116-1-git-send-email-shawn.lin@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 865 bytes --]
On Sun, Sep 06, 2015 at 09:13:28AM +0800, Shawn Lin wrote:
> @@ -460,7 +463,6 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
> i2s->playback_dma_data.addr = res->start + I2S_TXDR;
> i2s->playback_dma_data.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
> i2s->playback_dma_data.maxburst = 4;
> -
> i2s->capture_dma_data.addr = res->start + I2S_RXDR;
> i2s->capture_dma_data.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
> i2s->capture_dma_data.maxburst = 4;
This random whitespace change shouldn't be in here.
> @@ -489,6 +491,18 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
> goto err_pcm_register;
> }
>
> + dma_quirk = snd_dmaengine_pcm_get_quirks(&pdev->dev);
> + if (dma_quirk == ROCKCHIP_I2S_BROKEN_BURST_LEN) {
> + /*
I'd expect this to be a switch statement given the way this is written.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-09-11 11:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-06 1:11 [PATCH v4 0/10] Fix broken DMAFLUSHP on Rockchips platform Shawn Lin
2015-09-06 1:11 ` [PATCH v4 01/10] DMA: pl330: support burst mode for dev-to-mem and mem-to-dev transmit Shawn Lin
2015-09-06 1:12 ` [PATCH v4 02/10] Documentation: arm-pl330: add description of arm,pl330-broken-no-flushp Shawn Lin
2015-09-06 1:12 ` [PATCH v4 03/10] DMA: pl330: add quirk for broken no flushp Shawn Lin
2015-09-06 1:12 ` [PATCH v4 04/10] ARM: dts: Add arm,pl330-broken-no-flushp quirk for rk3288 platform Shawn Lin
2015-09-06 1:12 ` [PATCH v4 05/10] ARM: dts: Add arm,pl330-broken-no-flushp quirk for rk3xxx platform Shawn Lin
2015-09-06 1:12 ` [PATCH v4 06/10] dmaengine: add API for getting dma controller's quirk Shawn Lin
2015-09-06 1:12 ` [PATCH v4 07/10] DMA: pl330: implement dmaengine_get_quirks hook Shawn Lin
2015-09-06 1:13 ` [PATCH v4 08/10] spi: rockchip: modify DMA max burst to 1 Shawn Lin
2015-09-11 11:28 ` Mark Brown
2015-09-06 1:13 ` [PATCH v4 09/10] snd: dmaengine-pcm: add snd_dmaengine_pcm_get_quirks interface Shawn Lin
2015-09-06 1:13 ` [PATCH v4 10/10] ASoC: rockchip_i2s: modify DMA max burst to 1 Shawn Lin
2015-09-11 11:53 ` Mark Brown [this message]
2015-09-11 12:31 ` Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150911115331.GM12027@sirena.org.uk \
--to=broonie@kernel.org \
--cc=addy.ke@rock-chips.com \
--cc=alsa-devel@alsa-project.org \
--cc=cain.cai@rock-chips.com \
--cc=dianders@chromium.org \
--cc=dmaengine@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=olof@lixom.net \
--cc=olofj@google.com \
--cc=perex@perex.cz \
--cc=shawn.lin@rock-chips.com \
--cc=sonnyrao@chromium.org \
--cc=tiwai@suse.com \
--cc=vinod.koul@intel.com \
--cc=xjq@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®