mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Robert Richter <robert.richter@caviumnetworks.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Robert Richter <rric@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Tirumalesh Chalamarla <tchalamarla@cavium.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 5/5] irqchip, gicv3-its: Workaround for Cavium ThunderX errata 22375, 24313
Date: Fri, 18 Sep 2015 10:33:43 +0200	[thread overview]
Message-ID: <20150918083343.GY1820@rric.localdomain> (raw)
In-Reply-To: <55EDBC19.2010301@arm.com>

On 07.09.15 17:32:25, Marc Zyngier wrote:
> On 14/08/15 19:28, Robert Richter wrote:

> > +	if (its->flags & ITS_FLAGS_CAVIUM_THUNDERX) {
> > +		/*
> > +		 * erratum 22375: only alloc 8MB table size
> > +		 * erratum 24313: ignore memory access type
> > +		 */
> > +		cache	= 0;
> > +		ids	= 0x13;			/* 20 bits, 8MB */
> > +	} else {
> 
> You can move the typer definition here, as it is only used here.
> 
> > +		cache	= GITS_BASER_WaWb;
> > +		typer	= readq_relaxed(its->base + GITS_TYPER);
> > +		ids	= GITS_TYPER_DEVBITS(typer);
> > +	}

I am dropping this change as this would raise merge conflicts with
others, e.g. KVM patches.

-Robert

  reply	other threads:[~2015-09-18  8:34 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-14 18:28 [PATCH v4 0/5] irqchip, gicv3: Updates and Cavium ThunderX errata workarounds Robert Richter
2015-08-14 18:28 ` [PATCH v4 1/5] irqchip, gicv3-its: Add range check for number of allocated pages Robert Richter
2015-08-14 18:28 ` [PATCH v4 2/5] irqchip, gicv3: Workaround for Cavium ThunderX erratum 23154 Robert Richter
2015-08-17 16:40   ` Catalin Marinas
2015-08-19 15:43     ` Robert Richter
2015-08-17 17:00   ` David Daney
2015-08-19 16:05     ` Robert Richter
2015-09-07 16:54   ` Suzuki K. Poulose
2015-09-07 17:09     ` Marc Zyngier
2015-09-07 17:32       ` Robert Richter
2015-09-07 17:15     ` Catalin Marinas
2015-09-07 17:41       ` Suzuki K. Poulose
2015-09-08  9:00         ` Catalin Marinas
2015-09-08  9:09           ` Suzuki K. Poulose
2015-09-08  9:37             ` Catalin Marinas
2015-09-08 10:30               ` Suzuki K. Poulose
2015-08-14 18:28 ` [PATCH v4 3/5] irqchip, gicv3-its: Read typer register outside the loop Robert Richter
2015-08-14 18:28 ` [PATCH v4 4/5] irqchip, gicv3-its: Add HW revision detection and configuration Robert Richter
2015-09-07 16:26   ` Marc Zyngier
2015-08-14 18:28 ` [PATCH v4 5/5] irqchip, gicv3-its: Workaround for Cavium ThunderX errata 22375, 24313 Robert Richter
2015-09-07 16:32   ` Marc Zyngier
2015-09-18  8:33     ` Robert Richter [this message]
2015-09-07 16:35 ` [PATCH v4 0/5] irqchip, gicv3: Updates and Cavium ThunderX errata workarounds Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150918083343.GY1820@rric.localdomain \
    --to=robert.richter@caviumnetworks.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=rric@kernel.org \
    --cc=tchalamarla@cavium.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®