mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luis de Bethencourt <luis@debethencourt.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver
Date: Fri, 18 Sep 2015 21:09:12 +0200	[thread overview]
Message-ID: <20150918190912.GA1293@goodgumbo.baconseed.org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1509181456150.1681-100000@iolanthe.rowland.org>

On Fri, Sep 18, 2015 at 02:57:10PM -0400, Alan Stern wrote:
> On Fri, 18 Sep 2015, Luis de Bethencourt wrote:
> 
> > This platform driver has a OF device ID table but the OF module
> > alias information is not created so module autoloading won't work.
> > 
> > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> > ---
> >  drivers/usb/host/ehci-spear.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/host/ehci-spear.c
> > index 34e1474..be7bcf2 100644
> > --- a/drivers/usb/host/ehci-spear.c
> > +++ b/drivers/usb/host/ehci-spear.c
> > @@ -149,6 +149,7 @@ static const struct of_device_id spear_ehci_id_table[] = {
> >  	{ .compatible = "st,spear600-ehci", },
> >  	{ },
> >  };
> > +MODULE_DEVICE_TABLE(spear_ehci_id_table);
> 
> Shouldn't this be MODULE_DEVICE_TABLE(of, spear_ehci_id_table)?
> 
> Alan Stern
> 

Hi Alan,

Sorry about this. It looks like I accidentally sent a temporary version of
patch 1/4 and 3/4.

Sending the final and correct version now.

Thanks for the review,
Luis

      reply	other threads:[~2015-09-18 19:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18 18:21 Luis de Bethencourt
2015-09-18 18:57 ` Alan Stern
2015-09-18 19:09   ` Luis de Bethencourt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150918190912.GA1293@goodgumbo.baconseed.org \
    --to=luis@debethencourt.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®