From: Jason Cooper <jason@lakedaemon.net>
To: "Amber N. Adams" <amber@amberadams.co>
Cc: gregkh@linuxfoundation.org, eric.rost@mybabylon.net,
colinpatrickcronin@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: skein: Adds * on subsequent lines in block comment
Date: Mon, 21 Sep 2015 17:21:09 +0000 [thread overview]
Message-ID: <20150921172109.GH10628@io.lakedaemon.net> (raw)
In-Reply-To: <1442766726-32135-1-git-send-email-amber@amberadams.co>
On Sun, Sep 20, 2015 at 11:32:06AM -0500, Amber N. Adams wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: Block comments use * on subsequent lines
> +/*
> +Copyright (c) 2010 Werner Dittmann
>
> Signed-off-by: Amber N. Adams <amber@amberadams.co>
> ---
> drivers/staging/skein/skein_api.h | 48 +++++++++++++++++++--------------------
> 1 file changed, 24 insertions(+), 24 deletions(-)
Acked-by: Jason Cooper <jason@lakedaemon.net>
> diff --git a/drivers/staging/skein/skein_api.h b/drivers/staging/skein/skein_api.h
> index 7da8b38..4cf7003 100644
> --- a/drivers/staging/skein/skein_api.h
> +++ b/drivers/staging/skein/skein_api.h
> @@ -1,28 +1,28 @@
> -/*
> -Copyright (c) 2010 Werner Dittmann
> -
> -Permission is hereby granted, free of charge, to any person
> -obtaining a copy of this software and associated documentation
> -files (the "Software"), to deal in the Software without
> -restriction, including without limitation the rights to use,
> -copy, modify, merge, publish, distribute, sublicense, and/or sell
> -copies of the Software, and to permit persons to whom the
> -Software is furnished to do so, subject to the following
> -conditions:
> -
> -The above copyright notice and this permission notice shall be
> -included in all copies or substantial portions of the Software.
> -
> -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> -EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> -OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> -NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> -HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> -WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> -FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> -OTHER DEALINGS IN THE SOFTWARE.
> +/**
nit: the above should be /* instead of /**, but it's not worth a v2.
Thanks for the patch!
thx,
Jason.
> + * Copyright (c) 2010 Werner Dittmann
> + *
> + * Permission is hereby granted, free of charge, to any person
> + * obtaining a copy of this software and associated documentation
> + * files (the "Software"), to deal in the Software without
> + * restriction, including without limitation the rights to use,
> + * copy, modify, merge, publish, distribute, sublicense, and/or sell
> + * copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following
> + * conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> + * included in all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
>
> -*/
> + */
>
> #ifndef SKEINAPI_H
> #define SKEINAPI_H
> --
> 1.9.1
>
prev parent reply other threads:[~2015-09-21 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-20 16:32 Amber N. Adams
2015-09-21 17:21 ` Jason Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921172109.GH10628@io.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=amber@amberadams.co \
--cc=colinpatrickcronin@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=eric.rost@mybabylon.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®