mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] staging: skein: Adds * on subsequent lines in block comment
@ 2015-09-20 16:32 Amber N. Adams
  2015-09-21 17:21 ` Jason Cooper
  0 siblings, 1 reply; 2+ messages in thread
From: Amber N. Adams @ 2015-09-20 16:32 UTC (permalink / raw)
  To: gregkh
  Cc: eric.rost, jason, colinpatrickcronin, devel, linux-kernel,
	Amber N. Adams

This patch fixes the checkpatch.pl warning:

WARNING: Block comments use * on subsequent lines
+/*
+Copyright (c) 2010 Werner Dittmann

Signed-off-by: Amber N. Adams <amber@amberadams.co>
---
 drivers/staging/skein/skein_api.h | 48 +++++++++++++++++++--------------------
 1 file changed, 24 insertions(+), 24 deletions(-)

diff --git a/drivers/staging/skein/skein_api.h b/drivers/staging/skein/skein_api.h
index 7da8b38..4cf7003 100644
--- a/drivers/staging/skein/skein_api.h
+++ b/drivers/staging/skein/skein_api.h
@@ -1,28 +1,28 @@
-/*
-Copyright (c) 2010 Werner Dittmann
-
-Permission is hereby granted, free of charge, to any person
-obtaining a copy of this software and associated documentation
-files (the "Software"), to deal in the Software without
-restriction, including without limitation the rights to use,
-copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the
-Software is furnished to do so, subject to the following
-conditions:
-
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
-OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
-HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
-WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
-FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
-OTHER DEALINGS IN THE SOFTWARE.
+/**
+ * Copyright (c) 2010 Werner Dittmann
+ *
+ * Permission is hereby granted, free of charge, to any person
+ * obtaining a copy of this software and associated documentation
+ * files (the "Software"), to deal in the Software without
+ * restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following
+ * conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.

-*/
+ */

 #ifndef SKEINAPI_H
 #define SKEINAPI_H
--
1.9.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: skein: Adds * on subsequent lines in block comment
  2015-09-20 16:32 [PATCH] staging: skein: Adds * on subsequent lines in block comment Amber N. Adams
@ 2015-09-21 17:21 ` Jason Cooper
  0 siblings, 0 replies; 2+ messages in thread
From: Jason Cooper @ 2015-09-21 17:21 UTC (permalink / raw)
  To: Amber N. Adams; +Cc: gregkh, eric.rost, colinpatrickcronin, devel, linux-kernel

On Sun, Sep 20, 2015 at 11:32:06AM -0500, Amber N. Adams wrote:
> This patch fixes the checkpatch.pl warning:
> 
> WARNING: Block comments use * on subsequent lines
> +/*
> +Copyright (c) 2010 Werner Dittmann
> 
> Signed-off-by: Amber N. Adams <amber@amberadams.co>
> ---
>  drivers/staging/skein/skein_api.h | 48 +++++++++++++++++++--------------------
>  1 file changed, 24 insertions(+), 24 deletions(-)

Acked-by: Jason Cooper <jason@lakedaemon.net>

> diff --git a/drivers/staging/skein/skein_api.h b/drivers/staging/skein/skein_api.h
> index 7da8b38..4cf7003 100644
> --- a/drivers/staging/skein/skein_api.h
> +++ b/drivers/staging/skein/skein_api.h
> @@ -1,28 +1,28 @@
> -/*
> -Copyright (c) 2010 Werner Dittmann
> -
> -Permission is hereby granted, free of charge, to any person
> -obtaining a copy of this software and associated documentation
> -files (the "Software"), to deal in the Software without
> -restriction, including without limitation the rights to use,
> -copy, modify, merge, publish, distribute, sublicense, and/or sell
> -copies of the Software, and to permit persons to whom the
> -Software is furnished to do so, subject to the following
> -conditions:
> -
> -The above copyright notice and this permission notice shall be
> -included in all copies or substantial portions of the Software.
> -
> -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> -EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> -OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> -NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> -HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> -WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> -FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> -OTHER DEALINGS IN THE SOFTWARE.
> +/**

nit: the above should be /* instead of /**, but it's not worth a v2.
Thanks for the patch!

thx,

Jason.

> + * Copyright (c) 2010 Werner Dittmann
> + *
> + * Permission is hereby granted, free of charge, to any person
> + * obtaining a copy of this software and associated documentation
> + * files (the "Software"), to deal in the Software without
> + * restriction, including without limitation the rights to use,
> + * copy, modify, merge, publish, distribute, sublicense, and/or sell
> + * copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following
> + * conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> + * included in all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> 
> -*/
> + */
> 
>  #ifndef SKEINAPI_H
>  #define SKEINAPI_H
> --
> 1.9.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-09-21 17:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-20 16:32 [PATCH] staging: skein: Adds * on subsequent lines in block comment Amber N. Adams
2015-09-21 17:21 ` Jason Cooper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®