mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: nick <xerofoify@gmail.com>
Cc: cm224.lee@samsung.com, chao2.yu@samsung.com,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: Possible Bug in move_encrypted_block
Date: Mon, 21 Sep 2015 11:51:22 -0700	[thread overview]
Message-ID: <20150921185122.GD20551@jaegeuk-mac02.mot.com> (raw)
In-Reply-To: <55FD9D08.5050501@gmail.com>

Hi,

On Sat, Sep 19, 2015 at 01:36:08PM -0400, nick wrote:
> Greetings Jaeguek and others.
> Below are the lines fora possible bug in  move_encrypted_block:
> err = get_dnode_of_data(&dn, bidx, LOOKUP_NODE);
>         if (err)
>                 goto out;
> Also calls of get_dnode_of_data need to hold the semaphone for the superblock
> this call is being done on to avoid concurrent access on data being received

IIUC, the f2fs_lock_op() is not neeeded here. Do you mean this?
To be honest, I can't catch your point.

Thanks,

> here from the superblock and file system on disk. In addition unless I get a
> reply to this I will not be sending in a bug fix for this.
> Nick

           reply	other threads:[~2015-09-21 18:51 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <55FD9D08.5050501@gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150921185122.GD20551@jaegeuk-mac02.mot.com \
    --to=jaegeuk@kernel.org \
    --cc=chao2.yu@samsung.com \
    --cc=cm224.lee@samsung.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xerofoify@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®