mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata:Check if D2H Register FIS command fails in the function ahci_do_softreset
Date: Mon, 21 Sep 2015 15:02:51 -0400	[thread overview]
Message-ID: <20150921190251.GE13263@mtj.duckdns.org> (raw)
In-Reply-To: <1442630182-25614-1-git-send-email-xerofoify@gmail.com>

On Fri, Sep 18, 2015 at 10:36:22PM -0400, Nicholas Krause wrote:
> This fixes the missing error check and handling if the second D2H
> register command fails in the function fails.
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>

This isn't exactly a command execution and the success condition
checks are performed manually afterwards.  The ignoring of command
execution result is intentional there and the proposed change is
likely to cause more harm than good.  Unless there are specific cases
where the new code would behave better, I'd much rather leave it as it
is.

Thansk.

-- 
tejun

           reply	other threads:[~2015-09-21 19:02 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1442630182-25614-1-git-send-email-xerofoify@gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150921190251.GE13263@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xerofoify@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®