* Re: [PATCH] ata:Check if D2H Register FIS command fails in the function ahci_do_softreset
[not found] <1442630182-25614-1-git-send-email-xerofoify@gmail.com>
@ 2015-09-21 19:02 ` Tejun Heo
0 siblings, 0 replies; only message in thread
From: Tejun Heo @ 2015-09-21 19:02 UTC (permalink / raw)
To: Nicholas Krause; +Cc: linux-ide, linux-kernel
On Fri, Sep 18, 2015 at 10:36:22PM -0400, Nicholas Krause wrote:
> This fixes the missing error check and handling if the second D2H
> register command fails in the function fails.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
This isn't exactly a command execution and the success condition
checks are performed manually afterwards. The ignoring of command
execution result is intentional there and the proposed change is
likely to cause more harm than good. Unless there are specific cases
where the new code would behave better, I'd much rather leave it as it
is.
Thansk.
--
tejun
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-09-21 19:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1442630182-25614-1-git-send-email-xerofoify@gmail.com>
2015-09-21 19:02 ` [PATCH] ata:Check if D2H Register FIS command fails in the function ahci_do_softreset Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®