mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata:Fix error handling in the function ahci_pci_reset_controller
Date: Mon, 21 Sep 2015 15:07:54 -0400	[thread overview]
Message-ID: <20150921190754.GF13263@mtj.duckdns.org> (raw)
In-Reply-To: <1442633267-24297-1-git-send-email-xerofoify@gmail.com>

On Fri, Sep 18, 2015 at 11:27:47PM -0400, Nicholas Krause wrote:
> This fixes error handling in the function ahci_pci_reset_controller
> to properly check if the call to ahci_reset_controller fails and
> if return -EIO to this function's caller rather then continuing
> with this function's intended work if the controller cannot be
> reset properly for this ahci pci based device.

Maybe... I don't know.  What do we gain by failing resume?  Reporting
is fine but what'd be the recovery action?

Thanks.

-- 
tejun

           reply	other threads:[~2015-09-21 19:08 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1442633267-24297-1-git-send-email-xerofoify@gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150921190754.GF13263@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xerofoify@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®