mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Minfei Huang <mhuang@redhat.com>
To: Baoquan He <bhe@redhat.com>
Cc: Dave Young <dyoung@redhat.com>,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	kexec@lists.infradead.org, Minfei Huang <mnfhuang@gmail.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH] kexec: Add prefix "kexec" to output message
Date: Wed, 23 Sep 2015 13:44:34 +0800	[thread overview]
Message-ID: <20150923054434.GA3147@dhcp-128-25.nay.redhat.com> (raw)
In-Reply-To: <20150923052622.GB7739@dhcp-17-102.nay.redhat.com>

On 09/23/15 at 01:26pm, Baoquan He wrote:
> On 09/23/15 at 01:14pm, Minfei Huang wrote:
> > On 09/23/15 at 10:49am, Baoquan He wrote:
> > > This is weird, user really don't need to know each file. I saw you added
> > > a new file kexec_internal.h and all three files includes it. Why not doing
> > > it there to make it the same as before?
> > 
> > The output message format is incorrect, if other *.c (except for kexec*)
> > include the kexec_internal.h.
> 
> No, I assume Dave added kexec_internal.h not to be used by other *.c.
> It should be only used by kexec*.c
> 
> > 
> > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > 
> > How about defining the format like above in each *.c?

Ok. I can split this patch as two patches One for cleanup, other to fix
the prefix issue.

Thanks
Minfei

  reply	other threads:[~2015-09-23  5:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-13  7:15 Minfei Huang
2015-09-13 16:52 ` Eric W. Biederman
2015-09-14  7:50   ` Minfei Huang
2015-09-14  8:44     ` Dave Young
2015-09-15  3:08       ` Minfei Huang
2015-09-22 16:07         ` Minfei Huang
2015-09-23  1:37           ` Dave Young
2015-09-23  2:49             ` Baoquan He
2015-09-23  5:14               ` Minfei Huang
2015-09-23  5:26                 ` Baoquan He
2015-09-23  5:44                   ` Minfei Huang [this message]
2015-09-23  7:01               ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150923054434.GA3147@dhcp-128-25.nay.redhat.com \
    --to=mhuang@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mnfhuang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®