Re: [PATCH V2] kexec: Use file name as the output message prefix

[Minfei Huang <mnfhuang@gmail.com>]

On 09/25/15 at 01:24pm, Dave Young wrote:
> On 09/25/15 at 01:04pm, Dave Young wrote:
> > On 09/24/15 at 02:07pm, Minfei Huang wrote:
> > > kexec output message misses the prefix "kexec", when Dave Young split
> > > the kexec code. Now, we use file name as the output message prefix.
> > > 
> > > Currectly, the format of output message:
> 
> s/Currectly/Currently
> 
> > > [  140.290795] SYSC_kexec_load: hello, world
> > > [  140.291534] kexec: sanity_check_segment_list: hello, world
> > > 
> > > Ideally, the format of output message:
> > > [   30.791503] kexec: SYSC_kexec_load, Hello, world
> > > [   79.182752] kexec_core: sanity_check_segment_list, Hello, world
> > > 
> > > Remove the custom prefix "kexec" in output message.
> > > 
> > > Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
> > > ---
> > > v2: Use KBUILD_MODNAME as prefix, instead of custom string "kexec"
> > > ---
> > >  kernel/kexec.c      | 2 ++
> > >  kernel/kexec_core.c | 4 ++--
> > >  kernel/kexec_file.c | 2 ++
> > >  3 files changed, 6 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/kernel/kexec.c b/kernel/kexec.c
> > > index 4c5edc3..df772fc 100644
> > > --- a/kernel/kexec.c
> > > +++ b/kernel/kexec.c
> > > @@ -18,6 +18,8 @@
> > >  
> > >  #include "kexec_internal.h"
> > >  
> > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > > +
> > 
> > Move the micro to the top of the c file is better, ditto for other two files.
> 
> s/micro/macro
> 

Thanks, Dave.

I will post next version to correct them.

Thanks
Minfei

> > 
> > Otherwise:
> > Acked-by: Dave Young <dyoung@redhat.com>
> >