From: Borislav Petkov <bp@alien8.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andy Lutomirski <luto@amacapital.net>,
James Forcier <csssuf@csssuf.net>,
Dave Hansen <dave.hansen@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>, Jan Beulich <JBeulich@suse.com>,
X86 ML <x86@kernel.org>,
"Juergen Gross <jgross@suse.com, Toshi Kani" <toshi.kani@hp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Luis R. Rodriguez" <mcgrof@suse.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86/mm: Export cpu_tlbstate as non-GPL symbol
Date: Sun, 27 Sep 2015 13:28:54 +0200 [thread overview]
Message-ID: <20150927112853.GA8329@pd.tnic> (raw)
In-Reply-To: <alpine.DEB.2.11.1509271244140.4500@nanos>
On Sun, Sep 27, 2015 at 12:46:28PM +0200, Thomas Gleixner wrote:
> > https://github.com/kolasa/fglrx-13.152/blob/master/firegl_public.c
>
> I stopped looking at this line:
>
> MODULE_LICENSE("GPL\0Proprietary. (C) 2002 - ATI Technologies, Starnberg, GERMANY");
"GPL" *and* "Proprietary"??!
How does that even work?
Oh, that depends on the kernel version:
#if LINUX_VERSION_CODE < KERNEL_VERSION(3,19,0)
MODULE_LICENSE("Proprietary. (C) 2002 - ATI Technologies, Starnberg, GERMANY");
#else
MODULE_LICENSE("GPL\0Proprietary. (C) 2002 - ATI Technologies, Starnberg, GERMANY");
#endif
With that '\0' string terminator in there?! WTF now?!
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2015-09-27 11:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1442947897-14487-1-git-send-email-csssuf@csssuf.net>
2015-09-22 18:53 ` Andy Lutomirski
2015-09-22 18:57 ` Thomas Gleixner
2015-09-24 19:03 ` Andy Lutomirski
2015-09-27 10:46 ` Thomas Gleixner
2015-09-27 11:28 ` Borislav Petkov [this message]
2015-09-27 11:16 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150927112853.GA8329@pd.tnic \
--to=bp@alien8.de \
--cc=JBeulich@suse.com \
--cc=csssuf@csssuf.net \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mcgrof@suse.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hp.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®