From: Jean Delvare <jdelvare@suse.de>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Ingo Molnar <mingo@kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Benoit Cousson <bcousson@baylibre.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Corbet <corbet@lwn.net>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: p4-clockmod: Replace bool_int_array[NR_CPUS] with bitmap
Date: Mon, 28 Sep 2015 09:10:47 +0200 [thread overview]
Message-ID: <20150928091047.4d911780@endymion.delvare> (raw)
In-Reply-To: <56082E33.1020909@redhat.com>
On Sun, 27 Sep 2015 19:58:11 +0200, Denys Vlasenko wrote:
> On 09/27/2015 06:10 PM, Jean Delvare wrote:
> > Looks good, however I think you should #include <linux/bitmap.h> to
> > avoid build failures in the future or on certain architectures.
>
> <linux/cpumask.h> already includes <linux/bitmap.h>
> on any arch.
Today it does. Tomorrow, who knows.
> p4-clockmod.c builds only on x86 arch, it's Pentium 4
> on demand clock modulation/speed scaling module.
That is a valid point. My comment was generic, I did not pay attention
to the specific driver.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2015-09-28 7:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-26 12:47 [PATCH] x86/kgdb: " Denys Vlasenko
2015-09-26 12:47 ` [PATCH] cpufreq: p4-clockmod: " Denys Vlasenko
2015-09-26 22:07 ` Viresh Kumar
2015-09-27 16:10 ` Jean Delvare
2015-09-27 17:58 ` Denys Vlasenko
2015-09-28 7:10 ` Jean Delvare [this message]
2015-09-29 8:36 ` [tip:x86/debug] x86/kgdb: " tip-bot for Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150928091047.4d911780@endymion.delvare \
--to=jdelvare@suse.de \
--cc=bcousson@baylibre.com \
--cc=bgolaszewski@baylibre.com \
--cc=corbet@lwn.net \
--cc=dvlasenk@redhat.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®