From: Peter Zijlstra <peterz@infradead.org>
To: mingo@kernel.org
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
fweisbec@gmail.com, oleg@redhat.com, umgwanakikbuti@gmail.com,
tglx@linutronix.de, rostedt@goodmis.org,
Peter Zijlstra <peterz@infradead.org>
Subject: [RFC][PATCH 07/11] sched: Stop setting PREEMPT_ACTIVE
Date: Tue, 29 Sep 2015 11:28:32 +0200 [thread overview]
Message-ID: <20150929093520.316380243@infradead.org> (raw)
In-Reply-To: <20150929092825.540553633@infradead.org>
[-- Attachment #1: peterz-kill-preempt_active-7.patch --]
[-- Type: text/plain, Size: 2386 bytes --]
Now that nothing tests for PREEMPT_ACTIVE anymore, stop setting it.
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
include/linux/preempt.h | 12 ------------
kernel/sched/core.c | 19 ++++++-------------
2 files changed, 6 insertions(+), 25 deletions(-)
--- a/include/linux/preempt.h
+++ b/include/linux/preempt.h
@@ -146,18 +146,6 @@ extern void preempt_count_sub(int val);
#define preempt_count_inc() preempt_count_add(1)
#define preempt_count_dec() preempt_count_sub(1)
-#define preempt_active_enter() \
-do { \
- preempt_count_add(PREEMPT_ACTIVE + PREEMPT_DISABLE_OFFSET); \
- barrier(); \
-} while (0)
-
-#define preempt_active_exit() \
-do { \
- barrier(); \
- preempt_count_sub(PREEMPT_ACTIVE + PREEMPT_DISABLE_OFFSET); \
-} while (0)
-
#ifdef CONFIG_PREEMPT_COUNT
#define preempt_disable() \
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3190,9 +3190,9 @@ void __sched schedule_preempt_disabled(v
static void __sched notrace preempt_schedule_common(void)
{
do {
- preempt_active_enter();
+ preempt_disable();
__schedule(true);
- preempt_active_exit();
+ sched_preempt_enable_no_resched();
/*
* Check again in case we missed a preemption opportunity
@@ -3243,13 +3243,7 @@ asmlinkage __visible void __sched notrac
return;
do {
- /*
- * Use raw __prempt_count() ops that don't call function.
- * We can't call functions before disabling preemption which
- * disarm preemption tracing recursions.
- */
- __preempt_count_add(PREEMPT_ACTIVE + PREEMPT_DISABLE_OFFSET);
- barrier();
+ preempt_disable_notrace();
/*
* Needs preempt disabled in case user_exit() is traced
* and the tracer calls preempt_enable_notrace() causing
@@ -3259,8 +3253,7 @@ asmlinkage __visible void __sched notrac
__schedule(true);
exception_exit(prev_ctx);
- barrier();
- __preempt_count_sub(PREEMPT_ACTIVE + PREEMPT_DISABLE_OFFSET);
+ preempt_enable_no_resched_notrace();
} while (need_resched());
}
EXPORT_SYMBOL_GPL(preempt_schedule_notrace);
@@ -3283,11 +3276,11 @@ asmlinkage __visible void __sched preemp
prev_state = exception_enter();
do {
- preempt_active_enter();
+ preempt_disable();
local_irq_enable();
__schedule(true);
local_irq_disable();
- preempt_active_exit();
+ sched_preempt_enable_no_resched();
} while (need_resched());
exception_exit(prev_state);
next prev parent reply other threads:[~2015-09-29 9:43 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 9:28 [RFC][PATCH 00/11] sched: Killing PREEMPT_ACTIVE Peter Zijlstra
2015-09-29 9:28 ` [RFC][PATCH 01/11] sched: Simplify INIT_PREEMPT_COUNT Peter Zijlstra
2015-09-29 10:30 ` [tip:sched/core] sched/core: " tip-bot for Peter Zijlstra
2015-09-29 13:19 ` [RFC][PATCH 01/11] sched: " Frederic Weisbecker
2015-09-29 14:43 ` Steven Rostedt
2015-09-29 14:47 ` Peter Zijlstra
[not found] ` <20150929103729.00899e69@gandalf.local.home>
[not found] ` <20150929143559.GL3816@twins.programming.kicks-ass.net>
2015-09-29 15:00 ` Steven Rostedt
2015-09-29 15:05 ` Peter Zijlstra
2015-09-29 9:28 ` [RFC][PATCH 02/11] sched: Create preempt_count invariant Peter Zijlstra
2015-09-29 10:30 ` [tip:sched/core] sched/core: " tip-bot for Peter Zijlstra
2015-09-29 12:55 ` [RFC][PATCH 02/11] sched: " Frederic Weisbecker
2015-09-29 13:02 ` Peter Zijlstra
2015-09-29 14:40 ` Steven Rostedt
2015-09-29 13:11 ` Thomas Gleixner
2015-09-29 14:09 ` Peter Zijlstra
2015-09-29 9:28 ` [RFC][PATCH 03/11] sched: Robustify preemption leak checks Peter Zijlstra
2015-09-29 10:31 ` [tip:sched/core] sched/core: " tip-bot for Peter Zijlstra
2015-09-29 13:13 ` [RFC][PATCH 03/11] sched: " Thomas Gleixner
2015-09-29 13:25 ` Frederic Weisbecker
2015-09-29 14:24 ` Peter Zijlstra
2015-09-29 14:32 ` Frederic Weisbecker
2015-09-29 15:07 ` Steven Rostedt
2015-09-29 15:17 ` Peter Zijlstra
2015-09-29 9:28 ` [RFC][PATCH 04/11] sched: Rework TASK_DEAD preemption exception Peter Zijlstra
2015-09-29 13:13 ` Thomas Gleixner
2015-09-29 13:41 ` Frederic Weisbecker
2015-09-29 15:10 ` Steven Rostedt
2015-09-29 9:28 ` [RFC][PATCH 05/11] sched: Add preempt argument to __schedule() Peter Zijlstra
2015-09-29 13:14 ` Thomas Gleixner
2015-09-29 13:18 ` Frederic Weisbecker
2015-09-29 15:28 ` Steven Rostedt
2015-09-29 15:30 ` Steven Rostedt
2015-09-29 15:29 ` Peter Zijlstra
2015-09-29 9:28 ` [RFC][PATCH 06/11] sched: Fix trace_sched_switch() Peter Zijlstra
2015-09-29 13:15 ` Thomas Gleixner
2015-09-29 15:38 ` Steven Rostedt
2015-09-29 15:48 ` Peter Zijlstra
2015-09-29 16:30 ` Steven Rostedt
2015-09-29 9:28 ` Peter Zijlstra [this message]
2015-09-29 13:16 ` [RFC][PATCH 07/11] sched: Stop setting PREEMPT_ACTIVE Thomas Gleixner
2015-09-29 15:41 ` Steven Rostedt
2015-09-29 16:25 ` Peter Zijlstra
2015-09-29 9:28 ` [RFC][PATCH 08/11] sched: Simplify preempt_count tests Peter Zijlstra
2015-09-29 13:17 ` Thomas Gleixner
2015-09-29 15:42 ` Steven Rostedt
2015-09-29 9:28 ` [RFC][PATCH 09/11] sched, x86: Kill saved_preempt_count Peter Zijlstra
2015-09-29 13:18 ` Thomas Gleixner
2015-09-29 15:44 ` Steven Rostedt
2015-09-29 15:46 ` Peter Zijlstra
2015-09-29 9:28 ` [RFC][PATCH 10/11] sched: Kill PREEMPT_ACTIVE Peter Zijlstra
2015-09-29 13:18 ` Thomas Gleixner
2015-09-29 15:45 ` Steven Rostedt
2015-09-29 9:28 ` [RFC][PATCH 11/11] sched: More notrace Peter Zijlstra
2015-09-29 13:19 ` Thomas Gleixner
2015-09-29 15:58 ` Steven Rostedt
2015-09-29 10:27 ` [RFC][PATCH 12/11] sched: Add preempt_count invariant check Peter Zijlstra
2015-09-29 10:32 ` Peter Zijlstra
2015-09-29 10:56 ` [RFC][PATCH v2 " Peter Zijlstra
2015-09-29 11:55 ` Linus Torvalds
2015-09-29 11:55 ` Peter Zijlstra
2015-09-29 10:34 ` [RFC][PATCH 00/11] sched: Killing PREEMPT_ACTIVE Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150929093520.316380243@infradead.org \
--to=peterz@infradead.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®